GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-04-02 20:44:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

relay: prevent integer overflow in relay_open()

Browse source 
"subbuf_size" and "n_subbufs" come from the user and they need to be
capped to prevent an integer overflow.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Dan Carpenter 2012-02-10 09:03:58 +01:00 • committed by Jens Axboe
parent 306df0716a
commit f6302f1bcd
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
kernel/relay.c
View file

@ -164,10 +164,14 @@ depopulate:
*/ */
static struct rchan_buf *relay_create_buf(struct rchan *chan) static struct rchan_buf *relay_create_buf(struct rchan *chan)
{ {
struct rchan_buf *buf = kzalloc(sizeof(struct rchan_buf), GFP_KERNEL); struct rchan_buf *buf;
if (!buf)
if (chan->n_subbufs > UINT_MAX / sizeof(size_t *))
return NULL; return NULL;
buf = kzalloc(sizeof(struct rchan_buf), GFP_KERNEL);
if (!buf)
return NULL;
buf->padding = kmalloc(chan->n_subbufs * sizeof(size_t *), GFP_KERNEL); buf->padding = kmalloc(chan->n_subbufs * sizeof(size_t *), GFP_KERNEL);
if (!buf->padding) if (!buf->padding)
goto free_buf; goto free_buf;
@ -574,6 +578,8 @@ struct rchan *relay_open(const char *base_filename,
if (!(subbuf_size && n_subbufs)) if (!(subbuf_size && n_subbufs))
return NULL; return NULL;
if (subbuf_size > UINT_MAX / n_subbufs)
return NULL;
chan = kzalloc(sizeof(struct rchan), GFP_KERNEL); chan = kzalloc(sizeof(struct rchan), GFP_KERNEL);
if (!chan) if (!chan)