GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-21 22:21:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ARM: OMAP: mcbsp: Cleanup sidetone control initialization and make it generic

Browse source 
Sidetone resource is already registered for a device so there is no need
for cpu_is_omap34xx() and McBSP port number tests in the driver. We can
cleanup and make the code generic by dropping remaining CONFIG_ARCH_OMAP3
conditional compilations and then using sidetone resource and st_data
variable for runtime tests.

Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Signed-off-by: Tony Lindgren <tony@atomide.com>
This commit is contained in:
Jarkko Nikula 2011-09-26 10:45:45 +03:00 • committed by Tony Lindgren
parent 1743d14fb6
commit f821eece8b
2 changed files with 22 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

12
arch/arm/plat-omap/include/plat/mcbsp.h
View file

@ -353,9 +353,7 @@ struct omap_mcbsp {
spinlock_t lock; spinlock_t lock;
struct omap_mcbsp_platform_data *pdata; struct omap_mcbsp_platform_data *pdata;
struct clk *fclk; struct clk *fclk;
#ifdef CONFIG_ARCH_OMAP3
struct omap_mcbsp_st_data *st_data; struct omap_mcbsp_st_data *st_data;
#endif
int dma_op_mode; int dma_op_mode;
u16 max_tx_thres; u16 max_tx_thres;
u16 max_rx_thres; u16 max_rx_thres;
@ -402,21 +400,11 @@ void omap2_mcbsp1_mux_fsr_src(u8 mux);
int omap_mcbsp_dma_ch_params(unsigned int id, unsigned int stream); int omap_mcbsp_dma_ch_params(unsigned int id, unsigned int stream);
int omap_mcbsp_dma_reg_params(unsigned int id, unsigned int stream); int omap_mcbsp_dma_reg_params(unsigned int id, unsigned int stream);
#ifdef CONFIG_ARCH_OMAP3
/* Sidetone specific API */ /* Sidetone specific API */
int omap_st_set_chgain(unsigned int id, int channel, s16 chgain); int omap_st_set_chgain(unsigned int id, int channel, s16 chgain);
int omap_st_get_chgain(unsigned int id, int channel, s16 *chgain); int omap_st_get_chgain(unsigned int id, int channel, s16 *chgain);
int omap_st_enable(unsigned int id); int omap_st_enable(unsigned int id);
int omap_st_disable(unsigned int id); int omap_st_disable(unsigned int id);
int omap_st_is_enabled(unsigned int id); int omap_st_is_enabled(unsigned int id);
#else
static inline int omap_st_set_chgain(unsigned int id, int channel,
s16 chgain) { return 0; }
static inline int omap_st_get_chgain(unsigned int id, int channel,
s16 *chgain) { return 0; }
static inline int omap_st_enable(unsigned int id) { return 0; }
static inline int omap_st_disable(unsigned int id) { return 0; }
static inline int omap_st_is_enabled(unsigned int id) { return 0; }
#endif
#endif #endif

61
arch/arm/plat-omap/mcbsp.c
View file

@ -55,7 +55,6 @@ static int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache)
} }
} }
#ifdef CONFIG_ARCH_OMAP3
static void omap_mcbsp_st_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val) static void omap_mcbsp_st_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val)
{ {
__raw_writel(val, mcbsp->st_data->io_base_st + reg); __raw_writel(val, mcbsp->st_data->io_base_st + reg);
@ -65,7 +64,6 @@ static int omap_mcbsp_st_read(struct omap_mcbsp *mcbsp, u16 reg)
{ {
return __raw_readl(mcbsp->st_data->io_base_st + reg); return __raw_readl(mcbsp->st_data->io_base_st + reg);
} }
#endif
#define MCBSP_READ(mcbsp, reg) \ #define MCBSP_READ(mcbsp, reg) \
omap_mcbsp_read(mcbsp, OMAP_MCBSP_REG_##reg, 0) omap_mcbsp_read(mcbsp, OMAP_MCBSP_REG_##reg, 0)
@ -248,7 +246,6 @@ int omap_mcbsp_dma_reg_params(unsigned int id, unsigned int stream)
} }
EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); EXPORT_SYMBOL(omap_mcbsp_dma_reg_params);
#ifdef CONFIG_ARCH_OMAP3
static void omap_st_on(struct omap_mcbsp *mcbsp) static void omap_st_on(struct omap_mcbsp *mcbsp)
{ {
unsigned int w; unsigned int w;
@ -482,11 +479,6 @@ int omap_st_is_enabled(unsigned int id)
} }
EXPORT_SYMBOL(omap_st_is_enabled); EXPORT_SYMBOL(omap_st_is_enabled);
#else
static inline void omap_st_start(struct omap_mcbsp *mcbsp) {}
static inline void omap_st_stop(struct omap_mcbsp *mcbsp) {}
#endif
/* /*
* omap_mcbsp_set_rx_threshold configures the transmit threshold in words. * omap_mcbsp_set_rx_threshold configures the transmit threshold in words.
* The threshold parameter is 1 based, and it is converted (threshold - 1) * The threshold parameter is 1 based, and it is converted (threshold - 1)
@ -802,7 +794,7 @@ void omap_mcbsp_start(unsigned int id, int tx, int rx)
} }
mcbsp = id_to_mcbsp_ptr(id); mcbsp = id_to_mcbsp_ptr(id);
if (cpu_is_omap34xx()) if (mcbsp->st_data)
omap_st_start(mcbsp); omap_st_start(mcbsp);
/* Only enable SRG, if McBSP is master */ /* Only enable SRG, if McBSP is master */
@ -897,7 +889,7 @@ void omap_mcbsp_stop(unsigned int id, int tx, int rx)
MCBSP_WRITE(mcbsp, SPCR2, w & ~(1 << 6)); MCBSP_WRITE(mcbsp, SPCR2, w & ~(1 << 6));
} }
if (cpu_is_omap34xx()) if (mcbsp->st_data)
omap_st_stop(mcbsp); omap_st_stop(mcbsp);
} }
EXPORT_SYMBOL(omap_mcbsp_stop); EXPORT_SYMBOL(omap_mcbsp_stop);
@ -1030,7 +1022,6 @@ static const struct attribute_group additional_attr_group = {
.attrs = (struct attribute **)additional_attrs, .attrs = (struct attribute **)additional_attrs,
}; };
#ifdef CONFIG_ARCH_OMAP3
static ssize_t st_taps_show(struct device *dev, static ssize_t st_taps_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
@ -1098,10 +1089,9 @@ static const struct attribute_group sidetone_attr_group = {
.attrs = (struct attribute **)sidetone_attrs, .attrs = (struct attribute **)sidetone_attrs,
}; };
static int __devinit omap_st_add(struct omap_mcbsp *mcbsp) static int __devinit omap_st_add(struct omap_mcbsp *mcbsp,
struct resource *res)
{ {
struct platform_device *pdev;
struct resource *res;
struct omap_mcbsp_st_data *st_data; struct omap_mcbsp_st_data *st_data;
int err; int err;
@ -1111,9 +1101,6 @@ static int __devinit omap_st_add(struct omap_mcbsp *mcbsp)
goto err1; goto err1;
} }
pdev = container_of(mcbsp->dev, struct platform_device, dev);
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sidetone");
st_data->io_base_st = ioremap(res->start, resource_size(res)); st_data->io_base_st = ioremap(res->start, resource_size(res));
if (!st_data->io_base_st) { if (!st_data->io_base_st) {
err = -ENOMEM; err = -ENOMEM;
@ -1140,32 +1127,10 @@ static void __devexit omap_st_remove(struct omap_mcbsp *mcbsp)
{ {
struct omap_mcbsp_st_data *st_data = mcbsp->st_data; struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
if (st_data) {
sysfs_remove_group(&mcbsp->dev->kobj, &sidetone_attr_group); sysfs_remove_group(&mcbsp->dev->kobj, &sidetone_attr_group);
iounmap(st_data->io_base_st); iounmap(st_data->io_base_st);
kfree(st_data); kfree(st_data);
} }
}
static inline void __devinit omap34xx_device_init(struct omap_mcbsp *mcbsp)
{
if (cpu_is_omap34xx())
if (mcbsp->id == 2 || mcbsp->id == 3)
if (omap_st_add(mcbsp))
dev_warn(mcbsp->dev,
"Unable to create sidetone controls\n");
}
static inline void __devexit omap34xx_device_exit(struct omap_mcbsp *mcbsp)
{
if (cpu_is_omap34xx())
if (mcbsp->id == 2 || mcbsp->id == 3)
omap_st_remove(mcbsp);
}
#else
static inline void __devinit omap34xx_device_init(struct omap_mcbsp *mcbsp) {}
static inline void __devexit omap34xx_device_exit(struct omap_mcbsp *mcbsp) {}
#endif /* CONFIG_ARCH_OMAP3 */
/* /*
* McBSP1 and McBSP3 are directly mapped on 1610 and 1510. * McBSP1 and McBSP3 are directly mapped on 1610 and 1510.
@ -1291,11 +1256,22 @@ static int __devinit omap_mcbsp_probe(struct platform_device *pdev)
mcbsp->max_rx_thres = -EINVAL; mcbsp->max_rx_thres = -EINVAL;
} }
/* Initialize mcbsp properties for OMAP34XX if needed / applicable */ res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "sidetone");
omap34xx_device_init(mcbsp); if (res) {
ret = omap_st_add(mcbsp, res);
if (ret) {
dev_err(mcbsp->dev,
"Unable to create sidetone controls\n");
goto err_st;
}
}
return 0; return 0;
err_st:
if (mcbsp->pdata->buffer_size)
sysfs_remove_group(&mcbsp->dev->kobj,
&additional_attr_group);
err_thres: err_thres:
clk_put(mcbsp->fclk); clk_put(mcbsp->fclk);
err_res: err_res:
@ -1321,7 +1297,8 @@ static int __devexit omap_mcbsp_remove(struct platform_device *pdev)
sysfs_remove_group(&mcbsp->dev->kobj, sysfs_remove_group(&mcbsp->dev->kobj,
&additional_attr_group); &additional_attr_group);
omap34xx_device_exit(mcbsp); if (mcbsp->st_data)
omap_st_remove(mcbsp);
clk_put(mcbsp->fclk); clk_put(mcbsp->fclk);