GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-04-06 14:34:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

btrfs: hold a ref on the root in create_subvol

Browse source 
We're creating the new root here, but we should hold the ref until after
we've initialized the inode for it.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Josef Bacik 2020-01-24 09:32:32 -05:00 • committed by David Sterba
parent 8727002f79
commit fc92f79856
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
fs/btrfs/ioctl.c
View file

@ -672,10 +672,16 @@ static noinline int create_subvol(struct inode *dir,
btrfs_abort_transaction(trans, ret); btrfs_abort_transaction(trans, ret);
goto fail; goto fail;
} }
if (!btrfs_grab_fs_root(new_root)) {
ret = -ENOENT;
btrfs_abort_transaction(trans, ret);
goto fail;
}
btrfs_record_root_in_trans(trans, new_root); btrfs_record_root_in_trans(trans, new_root);
ret = btrfs_create_subvol_root(trans, new_root, root, new_dirid); ret = btrfs_create_subvol_root(trans, new_root, root, new_dirid);
btrfs_put_fs_root(new_root);
if (ret) { if (ret) {
/* We potentially lose an unused inode item here */ /* We potentially lose an unused inode item here */
btrfs_abort_transaction(trans, ret); btrfs_abort_transaction(trans, ret);