GitHub-Mirror/Star64_linux
2
0
Fork 0
mirror of https://github.com/Fishwaldo/Star64_linux.git synced 2025-06-28 17:41:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[PATCH] Fix get_request nastiness

Browse source 
get_request is now expected to be holding on to queue_lock, with interrupts
disabled, when it returns NULL; but one path forgot that, causing all kinds
of nastiness under swap load - badness backtraces, strange failures, BUGs.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Hugh Dickins 2005-06-29 15:15:40 +01:00 • committed by Linus Torvalds
parent 541cecac53
commit fd782a4a99
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/block/ll_rw_blk.c
View file

@ -1917,10 +1917,9 @@ get_rq:
* limit of requests, otherwise we could have thousands of requests * limit of requests, otherwise we could have thousands of requests
* allocated with any setting of ->nr_requests * allocated with any setting of ->nr_requests
*/ */
if (rl->count[rw] >= (3 * q->nr_requests / 2)) { if (rl->count[rw] >= (3 * q->nr_requests / 2))
spin_unlock_irq(q->queue_lock);
goto out; goto out;
}
rl->count[rw]++; rl->count[rw]++;
rl->starved[rw] = 0; rl->starved[rw] = 0;
if (rl->count[rw] >= queue_congestion_on_threshold(q)) if (rl->count[rw] >= queue_congestion_on_threshold(q))