No description
Find a file
Daniel Borkmann 134bbb7211 bpf: Don't use tnum_range on array range checking for poke descriptors
commit a657182a5c upstream.

Hsin-Wei reported a KASAN splat triggered by their BPF runtime fuzzer which
is based on a customized syzkaller:

  BUG: KASAN: slab-out-of-bounds in bpf_int_jit_compile+0x1257/0x13f0
  Read of size 8 at addr ffff888004e90b58 by task syz-executor.0/1489
  CPU: 1 PID: 1489 Comm: syz-executor.0 Not tainted 5.19.0 #1
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
  1.13.0-1ubuntu1.1 04/01/2014
  Call Trace:
   <TASK>
   dump_stack_lvl+0x9c/0xc9
   print_address_description.constprop.0+0x1f/0x1f0
   ? bpf_int_jit_compile+0x1257/0x13f0
   kasan_report.cold+0xeb/0x197
   ? kvmalloc_node+0x170/0x200
   ? bpf_int_jit_compile+0x1257/0x13f0
   bpf_int_jit_compile+0x1257/0x13f0
   ? arch_prepare_bpf_dispatcher+0xd0/0xd0
   ? rcu_read_lock_sched_held+0x43/0x70
   bpf_prog_select_runtime+0x3e8/0x640
   ? bpf_obj_name_cpy+0x149/0x1b0
   bpf_prog_load+0x102f/0x2220
   ? __bpf_prog_put.constprop.0+0x220/0x220
   ? find_held_lock+0x2c/0x110
   ? __might_fault+0xd6/0x180
   ? lock_downgrade+0x6e0/0x6e0
   ? lock_is_held_type+0xa6/0x120
   ? __might_fault+0x147/0x180
   __sys_bpf+0x137b/0x6070
   ? bpf_perf_link_attach+0x530/0x530
   ? new_sync_read+0x600/0x600
   ? __fget_files+0x255/0x450
   ? lock_downgrade+0x6e0/0x6e0
   ? fput+0x30/0x1a0
   ? ksys_write+0x1a8/0x260
   __x64_sys_bpf+0x7a/0xc0
   ? syscall_enter_from_user_mode+0x21/0x70
   do_syscall_64+0x3b/0x90
   entry_SYSCALL_64_after_hwframe+0x63/0xcd
  RIP: 0033:0x7f917c4e2c2d

The problem here is that a range of tnum_range(0, map->max_entries - 1) has
limited ability to represent the concrete tight range with the tnum as the
set of resulting states from value + mask can result in a superset of the
actual intended range, and as such a tnum_in(range, reg->var_off) check may
yield true when it shouldn't, for example tnum_range(0, 2) would result in
00XX -> v = 0000, m = 0011 such that the intended set of {0, 1, 2} is here
represented by a less precise superset of {0, 1, 2, 3}. As the register is
known const scalar, really just use the concrete reg->var_off.value for the
upper index check.

Fixes: d2e4c1e6c2 ("bpf: Constant map key tracking for prog array pokes")
Reported-by: Hsin-Wei Hung <hsinweih@uci.edu>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/r/984b37f9fdf7ac36831d2137415a4a915744c1b6.1661462653.git.daniel@iogearbox.net
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-04-19 17:53:27 +08:00
arch perf/x86/intel/ds: Fix precise store latency handling 2023-04-19 17:53:27 +08:00
block blk-mq: fix io hung due to missing commit_rqs 2023-04-19 17:53:27 +08:00
certs
crypto KEYS: asymmetric: enforce SM2 signature use pkey algo 2023-04-19 17:52:55 +08:00
Documentation Documentation/ABI: Mention retbleed vulnerability info file for sysfs 2023-04-19 17:53:27 +08:00
drivers scsi: storvsc: Remove WQ_MEM_RECLAIM from storvsc_error_wq 2023-04-19 17:53:27 +08:00
fs io_uring: fix issue with io_write() not always undoing sb_start_write() 2023-04-19 17:53:26 +08:00
include Revert "memcg: cleanup racy sum avoidance code" 2023-04-19 17:53:26 +08:00
init stack: Declare {randomize_,}kstack_offset to fix Sparse warnings 2023-04-19 17:52:12 +08:00
ipc
kernel bpf: Don't use tnum_range on array range checking for poke descriptors 2023-04-19 17:53:27 +08:00
lib ratelimit: Fix data-races in ___ratelimit(). 2023-04-19 17:53:23 +08:00
LICENSES
mm mm/hugetlb: fix hugetlb not supporting softdirty tracking 2023-04-19 17:53:26 +08:00
net mptcp: Fix crash due to tcp_tsorted_anchor was initialized before release skb 2023-04-19 17:53:27 +08:00
samples
scripts modules: Ensure natural alignment for .altinstructions and __bug_table sections 2023-04-19 17:53:14 +08:00
security apparmor: Fix memleak in aa_simple_write_to_buffer() 2023-04-19 17:53:01 +08:00
sound ALSA: control: Use deferred fasync helper 2023-04-19 17:53:15 +08:00
tools perf stat: Clear evsel->reset_group for each stat run 2023-04-19 17:53:27 +08:00
usr
virt KVM: Unconditionally get a ref to /dev/kvm module when creating a VM 2023-04-19 17:52:58 +08:00
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS Input: goodix - add a goodix.h header file 2023-04-19 17:50:59 +08:00
Makefile Linux 5.15.63 2023-04-19 17:53:17 +08:00
README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.