mirror of
https://github.com/Fishwaldo/Star64_linux.git
synced 2025-05-04 22:34:16 +00:00
49ecc587dc
This reverts commit 9ab7e76aef.
This patch was committed without maintainer approval and despite a number
of unaddressed concerns from review. There are several issues that
impede the acceptance of this patch and that make a reversion of this
particular instance of these changes the best way forward:
i) the patch contains several logically separate changes that would be
better served as smaller patches (for review purposes)
ii) functionality like the handling of end markers has been introduced
without further explanation
iii) symmetry between the handling of GTPv0 and GTPv1 has been
unnecessarily broken
iv) the patchset produces 'broken' packets when extension headers are
included
v) there are no available userspace tools to allow for testing this
functionality
vi) there is an unaddressed Coverity report against the patch concering
memory leakage
vii) most importantly, the patch contains a large amount of superfluous
churn that impedes other ongoing work with this driver
This patch will be reworked into a series that aligns with other
ongoing work and facilitates review.
Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
Acked-by: Harald Welte <laforge@gnumonks.org>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
37 lines
731 B
C
37 lines
731 B
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
#ifndef _UAPI_LINUX_GTP_H_
|
|
#define _UAPI_LINUX_GTP_H_
|
|
|
|
#define GTP_GENL_MCGRP_NAME "gtp"
|
|
|
|
enum gtp_genl_cmds {
|
|
GTP_CMD_NEWPDP,
|
|
GTP_CMD_DELPDP,
|
|
GTP_CMD_GETPDP,
|
|
|
|
GTP_CMD_MAX,
|
|
};
|
|
|
|
enum gtp_version {
|
|
GTP_V0 = 0,
|
|
GTP_V1,
|
|
};
|
|
|
|
enum gtp_attrs {
|
|
GTPA_UNSPEC = 0,
|
|
GTPA_LINK,
|
|
GTPA_VERSION,
|
|
GTPA_TID, /* for GTPv0 only */
|
|
GTPA_PEER_ADDRESS, /* Remote GSN peer, either SGSN or GGSN */
|
|
#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
|
|
GTPA_MS_ADDRESS,
|
|
GTPA_FLOW,
|
|
GTPA_NET_NS_FD,
|
|
GTPA_I_TEI, /* for GTPv1 only */
|
|
GTPA_O_TEI, /* for GTPv1 only */
|
|
GTPA_PAD,
|
|
__GTPA_MAX,
|
|
};
|
|
#define GTPA_MAX (__GTPA_MAX + 1)
|
|
|
|
#endif /* _UAPI_LINUX_GTP_H_ */
|