No description
Find a file
Vladimir Oltean d7795f8f26 net: mscc: ocelot: only drain extraction queue on error
It appears that the intention of this snippet of code is to not exit
ocelot_xtr_irq_handler() while in the middle of extracting a frame.
The problem in extracting it word by word is that future extraction
attempts are really easy to get desynchronized, since the IRQ handler
assumes that the first 16 bytes are the IFH, which give further
information about the frame, such as frame length.

But during normal operation, "err" will not be 0, but 4, set from here:

		for (i = 0; i < OCELOT_TAG_LEN / 4; i++) {
			err = ocelot_rx_frame_word(ocelot, grp, true, &ifh[i]);
			if (err != 4)
				break;
		}

		if (err != 4)
			break;

In that case, draining the extraction queue is a no-op. So explicitly
make this code execute only on negative err.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-02-14 17:31:43 -08:00
arch
block
certs
crypto
Documentation dt-bindings: net: xilinx_axienet: add xlnx,switch-x-sgmii attribute 2021-02-12 17:38:53 -08:00
drivers net: mscc: ocelot: only drain extraction queue on error 2021-02-14 17:31:43 -08:00
fs
include skbuff: queue NAPI_MERGED_FREE skbs into NAPI cache instead of freeing 2021-02-13 14:32:04 -08:00
init
ipc
kernel
lib
LICENSES
mm
net skbuff: queue NAPI_MERGED_FREE skbs into NAPI cache instead of freeing 2021-02-13 14:32:04 -08:00
samples
scripts
security
sound
tools selftests: tc: Add generic mpls matching support for tc-flower 2021-02-12 17:13:52 -08:00
usr
virt
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap
COPYING
CREDITS
Kbuild
Kconfig
MAINTAINERS
Makefile
README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.