No description
Find a file
Magnus Karlsson dd4d45e940 xsk: fix refcount underflow in error path
commit 85c2c79a07 upstream.

Fix a refcount underflow problem reported by syzbot that can happen
when a system is running out of memory. If xp_alloc_tx_descs() fails,
and it can only fail due to not having enough memory, then the error
path is triggered. In this error path, the refcount of the pool is
decremented as it has incremented before. However, the reference to
the pool in the socket was not nulled. This means that when the socket
is closed later, the socket teardown logic will think that there is a
pool attached to the socket and try to decrease the refcount again,
leading to a refcount underflow.

I chose this fix as it involved adding just a single line. Another
option would have been to move xp_get_pool() and the assignment of
xs->pool to after the if-statement and using xs_umem->pool instead of
xs->pool in the whole if-statement resulting in somewhat simpler code,
but this would have led to much more churn in the code base perhaps
making it harder to backport.

Fixes: ba3beec2ec ("xsk: Fix possible crash when multiple sockets are created")
Reported-by: syzbot+8ada0057e69293a05fd4@syzkaller.appspotmail.com
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Link: https://lore.kernel.org/r/20230809142843.13944-1-magnus.karlsson@gmail.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-08-20 16:01:42 +08:00
arch x86: Move gds_ucode_mitigated() declaration to header 2023-08-20 16:01:41 +08:00
block block/partition: fix signedness issue for Amiga partitions 2023-08-20 15:24:51 +08:00
certs certs/blacklist_hashes.c: fix const confusion in certs blacklist 2023-04-19 17:50:34 +08:00
crypto KEYS: asymmetric: Copy sig and digest in public_key_verify_signature() 2023-08-20 15:21:12 +08:00
Documentation iommu/arm-smmu-v3: Document nesting-related errata 2023-08-20 16:01:31 +08:00
drivers mISDN: Update parameter type of dsp_cmx_send() 2023-08-20 16:01:42 +08:00
fs nilfs2: fix use-after-free of nilfs_root in dirtying inodes via iput 2023-08-20 16:01:39 +08:00
include bpf, sockmap: Fix bug that strp_done cannot be called 2023-08-20 16:01:42 +08:00
init x86/mm: Initialize text poking earlier 2023-08-20 16:01:29 +08:00
io_uring io_uring: correct check for O_TMPFILE 2023-08-20 16:01:40 +08:00
ipc ipc/sem: Fix dangling sem_array access in semtimedop race 2023-04-19 17:56:54 +08:00
kernel bpf: aggressively forget precise markings during state checkpointing 2023-08-20 16:01:39 +08:00
lib test_firmware: return ENOMEM instead of ENOSPC on failed memory allocation 2023-08-20 15:24:43 +08:00
LICENSES LICENSES/dual/CC-BY-4.0: Git rid of "smart quotes" 2021-07-15 06:31:24 -06:00
mm mm/damon/ops-common: atomically test and clear young on ptes and pmds 2023-08-20 15:24:58 +08:00
net xsk: fix refcount underflow in error path 2023-08-20 16:01:42 +08:00
samples samples: ftrace: Save required argument registers in sample trampolines 2023-08-20 16:01:05 +08:00
scripts kbuild: Disable GCOV for *.mod.o 2023-08-20 15:24:38 +08:00
security security: keys: Modify mismatched function name 2023-08-20 16:01:12 +08:00
sound ASoC: cs42l51: fix driver to properly autoload with automatic module loading 2023-08-20 16:01:27 +08:00
tools selftests: forwarding: tc_flower: Relax success criterion 2023-08-20 16:01:41 +08:00
usr usr/include/Makefile: add linux/nfc.h to the compile-test coverage 2023-04-19 17:44:58 +08:00
virt KVM: Grab a reference to KVM for VM and vCPU stats file descriptors 2023-08-20 16:01:23 +08:00
.clang-format clang-format: Update with the latest for_each macro list 2021-05-12 23:32:39 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore .gitignore: ignore only top-level modules.builtin 2021-05-02 00:43:35 +09:00
.mailmap mailmap: add Andrej Shadura 2021-10-18 20:22:03 -10:00
COPYING COPYING: state that all contributions really are covered by this file 2020-02-10 13:32:20 -08:00
CREDITS MAINTAINERS: Move Daniel Drake to credits 2021-09-21 08:34:58 +03:00
Kbuild kbuild: rename hostprogs-y/always to hostprogs/always-y 2020-02-04 01:53:07 +09:00
Kconfig kbuild: ensure full rebuild when the compiler is updated 2020-05-12 13:28:33 +09:00
MAINTAINERS cifs: missing directory in MAINTAINERS file 2023-08-20 16:01:16 +08:00
Makefile Linux 5.15.126 2023-08-20 16:01:38 +08:00
README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.