GitHub-Mirror/bl_mcu_sdk
2
0
Fork 0
mirror of https://github.com/Fishwaldo/bl_mcu_sdk.git synced 2025-07-07 13:28:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix build errors in entry.S. allows helloworld to compile and link.

Browse source 
1) __riscv_float_abi_single is not in the provided preprocessor namespace.
The default build sets -Werror and has -Warn implicitly. Testing something
that's not defined with an #if is therefore an error.
This is possibly a behavior change. If your builds ever define that AND
set it to 0, this way will fail, but #if defined (foo) + #if foo is akward
and probably not what you intended.

2) "csrw mtvt, t0" is not legal in at least
GNU assembler (GNU Binutils) 2.35
   Fortunately, riscv_encoding.h #defines a perfectly lovely value of
$0x307 that's appropriate for the chips AND is compatible with more assemblers.
This appears to be  an extension in
GNU assembler (SiFive Binutils 2.32.0-2019.08.0) 2.32
(present in bl_io_sdk, as provided by SiFive)
and that's probably what's in  your $PATH, but not relying on vendor
extension in this case is dead easy.

Two distinct problems. No, I'm not making different pull requests.
...this is a lot of words for a two line change. :-)
This commit is contained in:
Robert Lipe 2021-06-18 11:03:20 -05:00 • committed by pfchen
parent 1223e91a16
commit c39ba09f3d
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/bl702_driver/startup/GCC/entry.S
View file

@ -52,7 +52,8 @@ _enter:
/* Intial the mtvt, MUST BE 64 bytes aligned*/ /* Intial the mtvt, MUST BE 64 bytes aligned*/
.weak __Vectors .weak __Vectors
la t0, __Vectors la t0, __Vectors
csrw mtvt, t0 // From drivers/bl702_driver/risc-v/Core/Include/riscv_encoding.h
csrw CSR_MTVT, t0
#ifdef __riscv_float_abi_single #ifdef __riscv_float_abi_single
/* deal with FP */ /* deal with FP */