From 7d1c87ddbd48807cf8b283b1290d33561d2dad1f Mon Sep 17 00:00:00 2001 From: Akinori MUSHA Date: Thu, 19 Jan 2017 17:38:27 +0900 Subject: [PATCH] Slightly fix the regexps The quantifier `+?` does not make sense here, so I guess you actually meant this. --- spec/models/agents/twitter_favorites_spec.rb | 4 +++- spec/models/agents/twitter_search_agent_spec.rb | 4 +++- spec/models/agents/twitter_user_agent_spec.rb | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/spec/models/agents/twitter_favorites_spec.rb b/spec/models/agents/twitter_favorites_spec.rb index b8605902..f4799b97 100644 --- a/spec/models/agents/twitter_favorites_spec.rb +++ b/spec/models/agents/twitter_favorites_spec.rb @@ -2,7 +2,9 @@ require 'rails_helper' describe Agents::TwitterFavorites do before do - stub_request(:any, /tectonic.+?tweet_mode=extended/).to_return(body: File.read(Rails.root.join("spec/data_fixtures/user_fav_tweets.json")), status: 200) + stub_request(:any, /tectonic.*[?&]tweet_mode=extended/). + to_return(body: File.read(Rails.root.join("spec/data_fixtures/user_fav_tweets.json")), + status: 200) end before do diff --git a/spec/models/agents/twitter_search_agent_spec.rb b/spec/models/agents/twitter_search_agent_spec.rb index c089c274..d2c0da5a 100644 --- a/spec/models/agents/twitter_search_agent_spec.rb +++ b/spec/models/agents/twitter_search_agent_spec.rb @@ -3,7 +3,9 @@ require 'rails_helper' describe Agents::TwitterSearchAgent do before do # intercept the twitter API request - stub_request(:any, /freebandnames.+?tweet_mode=extended/).to_return(body: File.read(Rails.root.join("spec/data_fixtures/search_tweets.json")), status: 200) + stub_request(:any, /freebandnames.*[?&]tweet_mode=extended/). + to_return(body: File.read(Rails.root.join("spec/data_fixtures/search_tweets.json")), + status: 200) @opts = { search: "freebandnames", expected_update_period_in_days: "2", diff --git a/spec/models/agents/twitter_user_agent_spec.rb b/spec/models/agents/twitter_user_agent_spec.rb index a4dff9be..f8607e4b 100644 --- a/spec/models/agents/twitter_user_agent_spec.rb +++ b/spec/models/agents/twitter_user_agent_spec.rb @@ -3,7 +3,9 @@ require 'rails_helper' describe Agents::TwitterUserAgent do before do # intercept the twitter API request for @tectonic's user profile - stub_request(:any, "https://api.twitter.com/1.1/statuses/user_timeline.json?contributor_details=true&count=200&exclude_replies=false&include_entities=true&include_rts=true&screen_name=tectonic&tweet_mode=extended").to_return(:body => File.read(Rails.root.join("spec/data_fixtures/user_tweets.json")), :status => 200) + stub_request(:any, "https://api.twitter.com/1.1/statuses/user_timeline.json?contributor_details=true&count=200&exclude_replies=false&include_entities=true&include_rts=true&screen_name=tectonic&tweet_mode=extended"). + to_return(body: File.read(Rails.root.join("spec/data_fixtures/user_tweets.json")), + status: 200) @opts = { :username => "tectonic",