GitHub-Mirror/huginn
2
0
Fork 0
mirror of https://github.com/Fishwaldo/huginn.git synced 2025-03-15 19:31:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2103 from dsander/fix-peak-detector

Browse source 
Prevent PeakDetectorAgent from storing invalid data in it's memory
This commit is contained in:
Akinori MUSHA 2017-09-01 08:24:10 +09:00 • committed by GitHub
commit 8ba1adc0a6
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/agents/peak_detector_agent.rb
View file

@ -138,7 +138,7 @@ module Agents
def remember(group, event)
memory['data'] ||= {}
memory['data'][group] ||= []
memory['data'][group] << [ Utils.value_at(event.payload, interpolated['value_path']), event.created_at.to_i ]
memory['data'][group] << [ Utils.value_at(event.payload, interpolated['value_path']).to_f, event.created_at.to_i ]
cleanup group
end

7
spec/models/agents/peak_detector_agent_spec.rb
View file

@ -78,6 +78,13 @@ describe Agents::PeakDetectorAgent do
:pattern => { 'filter' => "something" })
expect(@agent.memory['peaks']['something'].length).to eq(1)
end
it 'raised an exception if the extracted data can not be casted to a float' do
event = Event.new(payload: {count: ["not working"]})
expect {
@agent.receive([event])
}.to raise_error(NoMethodError, /undefined method `to_f'/)
end
end
describe "validation" do