From c9f71ce328945756f45010460f7e2e5fd4b14e88 Mon Sep 17 00:00:00 2001 From: Akinori MUSHA Date: Fri, 17 Mar 2017 02:02:46 +0900 Subject: [PATCH] Use an infinite sequence and save a query --- app/models/agent.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/agent.rb b/app/models/agent.rb index a797f0a0..aea2e11b 100644 --- a/app/models/agent.rb +++ b/app/models/agent.rb @@ -296,7 +296,7 @@ class Agent < ActiveRecord::Base new(original.slice(:type, :options, :service_id, :schedule, :controller_ids, :control_target_ids, :source_ids, :keep_events_for, :propagate_immediately, :scenario_ids)) { |clone| # Give it a unique name - 2.upto(count) do |i| + 2.step do |i| name = '%s (%d)' % [original.name, i] unless exists?(name: name) clone.name = name