GitHub-Mirror/linux-bl808
2
0
Fork 0
mirror of https://github.com/Fishwaldo/linux-bl808.git synced 2025-06-17 20:25:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"

Browse source 
Revert the commit e2ca690b65 ("ipv4/icmp: redirect messages
can use the ingress daddr as source"), which tried to introduce a more
suitable behaviour for ICMP redirect messages generated by VRRP routers.
However RFC 5798 section 8.1.1 states:

    The IPv4 source address of an ICMP redirect should be the address
    that the end-host used when making its next-hop routing decision.

while said commit used the generating packet destination
address, which do not match the above and in most cases leads to
no redirect packets to be generated.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Paolo Abeni 2015-10-14 14:25:53 +02:00 • committed by David S. Miller
parent 7d1f6411b0
commit 02a6d6136f
4 changed files with 3 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

9
net/ipv4/icmp.c
View file

@ -659,9 +659,7 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
*/
saddr = iph->daddr;
if (!((type == ICMP_REDIRECT) &&
net->ipv4.sysctl_icmp_redirects_use_orig_daddr) &&
!(rt->rt_flags & RTCF_LOCAL)) {
if (!(rt->rt_flags & RTCF_LOCAL)) {
struct net_device *dev = NULL;
rcu_read_lock();
@ -1224,11 +1222,6 @@ static int __net_init icmp_sk_init(struct net *net)
net->ipv4.sysctl_icmp_ratemask = 0x1818;
net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr = 0;
/* Control paramerer - use the daddr of originating packets as saddr
* in redirect messages?
*/
net->ipv4.sysctl_icmp_redirects_use_orig_daddr = 0;
return 0;
fail: