GitHub-Mirror/linux-bl808
2
0
Fork 0
mirror of https://github.com/Fishwaldo/linux-bl808.git synced 2025-06-06 22:55:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

rcu: Adjust ->lock acquisition for tasks no longer migrating

Browse source 
Tasks are no longer migrated away from a given rcu_node structure
when all CPUs corresponding to that rcu_node structure have gone offline.
This means that rcu_read_unlock_special() no longer needs to loop
retrying rcu_node ->lock acquisition because the current task is
guaranteed to stay put.

This commit takes a small and paranoid step towards relying on this
guarantee by placing a WARN_ON_ONCE() just after the early exit from
the lock-acquisition loop.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
This commit is contained in:
Paul E. McKenney 2015-03-08 14:20:30 -07:00
parent ea46351cea
commit 0a0ba1c93f
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
kernel/rcu/tree_plugin.h
View file

@ -307,9 +307,11 @@ void rcu_read_unlock_special(struct task_struct *t)
t->rcu_read_unlock_special.b.blocked = false; t->rcu_read_unlock_special.b.blocked = false;
/* /*
* Remove this task from the list it blocked on. The * Remove this task from the list it blocked on. The task
* task can migrate while we acquire the lock, but at * now remains queued on the rcu_node corresponding to
* most one time. So at most two passes through loop. * the CPU it first blocked on, so the first attempt to
* acquire the task's rcu_node's ->lock will succeed.
* Keep the loop and add a WARN_ON() out of sheer paranoia.
*/ */
for (;;) { for (;;) {
rnp = t->rcu_blocked_node; rnp = t->rcu_blocked_node;
@ -317,6 +319,7 @@ void rcu_read_unlock_special(struct task_struct *t)
smp_mb__after_unlock_lock(); smp_mb__after_unlock_lock();
if (rnp == t->rcu_blocked_node) if (rnp == t->rcu_blocked_node)
break; break;
WARN_ON_ONCE(1);
raw_spin_unlock(&rnp->lock); /* irqs remain disabled. */ raw_spin_unlock(&rnp->lock); /* irqs remain disabled. */
} }
empty_norm = !rcu_preempt_blocked_readers_cgp(rnp); empty_norm = !rcu_preempt_blocked_readers_cgp(rnp);