GitHub-Mirror/linux-bl808
2
0
Fork 0
mirror of https://github.com/Fishwaldo/linux-bl808.git synced 2025-03-18 21:14:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mmap_lock: change trace and locking order

Browse source 
Print to the trace log before releasing the lock to avoid racing with
other trace log printers of the same lock type.

Link: https://lkml.kernel.org/r/20210903022041.1843024-1-Liam.Howlett@oracle.com
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Michel Lespinasse <walken.cr@gmail.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Liam Howlett 2021-09-08 18:10:14 -07:00 • committed by Linus Torvalds
parent 053cfda102
commit 1099431608
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
include/linux/mmap_lock.h
View file

@ -101,14 +101,14 @@ static inline bool mmap_write_trylock(struct mm_struct *mm)
static inline void mmap_write_unlock(struct mm_struct *mm) static inline void mmap_write_unlock(struct mm_struct *mm)
{ {
up_write(&mm->mmap_lock);
__mmap_lock_trace_released(mm, true); __mmap_lock_trace_released(mm, true);
up_write(&mm->mmap_lock);
} }
static inline void mmap_write_downgrade(struct mm_struct *mm) static inline void mmap_write_downgrade(struct mm_struct *mm)
{ {
downgrade_write(&mm->mmap_lock);
__mmap_lock_trace_acquire_returned(mm, false, true); __mmap_lock_trace_acquire_returned(mm, false, true);
downgrade_write(&mm->mmap_lock);
} }
static inline void mmap_read_lock(struct mm_struct *mm) static inline void mmap_read_lock(struct mm_struct *mm)
@ -140,8 +140,8 @@ static inline bool mmap_read_trylock(struct mm_struct *mm)
static inline void mmap_read_unlock(struct mm_struct *mm) static inline void mmap_read_unlock(struct mm_struct *mm)
{ {
up_read(&mm->mmap_lock);
__mmap_lock_trace_released(mm, false); __mmap_lock_trace_released(mm, false);
up_read(&mm->mmap_lock);
} }
static inline bool mmap_read_trylock_non_owner(struct mm_struct *mm) static inline bool mmap_read_trylock_non_owner(struct mm_struct *mm)
@ -155,8 +155,8 @@ static inline bool mmap_read_trylock_non_owner(struct mm_struct *mm)
static inline void mmap_read_unlock_non_owner(struct mm_struct *mm) static inline void mmap_read_unlock_non_owner(struct mm_struct *mm)
{ {
up_read_non_owner(&mm->mmap_lock);
__mmap_lock_trace_released(mm, false); __mmap_lock_trace_released(mm, false);
up_read_non_owner(&mm->mmap_lock);
} }
static inline void mmap_assert_locked(struct mm_struct *mm) static inline void mmap_assert_locked(struct mm_struct *mm)