mirror of
https://github.com/Fishwaldo/linux-bl808.git
synced 2025-06-17 20:25:19 +00:00
module: fix sysfs cleanup for !CONFIG_SYSFS
Restore the stub module_remove_modinfo_attrs, remove the now-unused !CONFIG_SYSFS module_sysfs_init. Also, rename mod_kobject_remove() to mod_sysfs_teardown() as it is the logical counterpart to mod_sysfs_setup now. Reported-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
parent
8f6d037815
commit
36b0360d17
1 changed files with 6 additions and 7 deletions
|
@ -1504,11 +1504,6 @@ static void mod_sysfs_fini(struct module *mod)
|
||||||
|
|
||||||
#else /* !CONFIG_SYSFS */
|
#else /* !CONFIG_SYSFS */
|
||||||
|
|
||||||
static int mod_sysfs_init(struct module *mod)
|
|
||||||
{
|
|
||||||
return 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
static int mod_sysfs_setup(struct module *mod,
|
static int mod_sysfs_setup(struct module *mod,
|
||||||
const struct load_info *info,
|
const struct load_info *info,
|
||||||
struct kernel_param *kparam,
|
struct kernel_param *kparam,
|
||||||
|
@ -1521,13 +1516,17 @@ static void mod_sysfs_fini(struct module *mod)
|
||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void module_remove_modinfo_attrs(struct module *mod)
|
||||||
|
{
|
||||||
|
}
|
||||||
|
|
||||||
static void del_usage_links(struct module *mod)
|
static void del_usage_links(struct module *mod)
|
||||||
{
|
{
|
||||||
}
|
}
|
||||||
|
|
||||||
#endif /* CONFIG_SYSFS */
|
#endif /* CONFIG_SYSFS */
|
||||||
|
|
||||||
static void mod_kobject_remove(struct module *mod)
|
static void mod_sysfs_teardown(struct module *mod)
|
||||||
{
|
{
|
||||||
del_usage_links(mod);
|
del_usage_links(mod);
|
||||||
module_remove_modinfo_attrs(mod);
|
module_remove_modinfo_attrs(mod);
|
||||||
|
@ -1557,7 +1556,7 @@ static void free_module(struct module *mod)
|
||||||
mutex_lock(&module_mutex);
|
mutex_lock(&module_mutex);
|
||||||
stop_machine(__unlink_module, mod, NULL);
|
stop_machine(__unlink_module, mod, NULL);
|
||||||
mutex_unlock(&module_mutex);
|
mutex_unlock(&module_mutex);
|
||||||
mod_kobject_remove(mod);
|
mod_sysfs_teardown(mod);
|
||||||
|
|
||||||
/* Remove dynamic debug info */
|
/* Remove dynamic debug info */
|
||||||
ddebug_remove_module(mod->name);
|
ddebug_remove_module(mod->name);
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue