drm/ast: Managed device release

This turns the ast's device cleanup code into a managed release helper
function. Note that the code uses devres helpers. The release function
switches the device back to VGA mode and therefore runs during HW device
cleanup; not at DRM device cleanup.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200730135206.30239-10-tzimmermann@suse.de
This commit is contained in:
Thomas Zimmermann 2020-07-30 15:52:06 +02:00
parent 4bc85b82c8
commit cff0adca1e
3 changed files with 19 additions and 21 deletions

View file

@ -120,35 +120,24 @@ static int ast_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
return ret;
ast = ast_device_create(&ast_driver, pdev, ent->driver_data);
if (IS_ERR(ast)) {
ret = PTR_ERR(ast);
goto err_drm_dev_put;
}
if (IS_ERR(ast))
return PTR_ERR(ast);
dev = &ast->base;
ret = drm_dev_register(dev, ent->driver_data);
if (ret)
goto err_ast_device_destroy;
return ret;
drm_fbdev_generic_setup(dev, 32);
return 0;
err_ast_device_destroy:
ast_device_destroy(ast);
err_drm_dev_put:
drm_dev_put(dev);
return ret;
}
static void ast_pci_remove(struct pci_dev *pdev)
{
struct drm_device *dev = pci_get_drvdata(pdev);
struct ast_private *ast = to_ast_private(dev);
drm_dev_unregister(dev);
ast_device_destroy(ast);
drm_dev_put(dev);
}
static int ast_drm_freeze(struct drm_device *dev)