GitHub-Mirror/linux-bl808
2
0
Fork 0
mirror of https://github.com/Fishwaldo/linux-bl808.git synced 2025-06-17 20:25:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ipack: split ipack_device_register() in several functions

Browse source 
One function is ipack_device_init(). If it fails, the caller should execute
ipack_put_device().

The second function is ipack_device_add that only adds the device. If
it fails, the caller should execute ipack_put_device().

Then the device is removed with refcount = 0, as device_register() kernel
documentation says.

ipack_device_del() is added to remove the device.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Samuel Iglesias Gonsalvez 2013-03-08 09:21:47 +01:00 • committed by Greg Kroah-Hartman
parent fa882867ae
commit e926301b39
3 changed files with 57 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

39
include/linux/ipack.h
View file

@ -207,19 +207,38 @@ int ipack_driver_register(struct ipack_driver *edrv, struct module *owner,
void ipack_driver_unregister(struct ipack_driver *edrv);
/**
* ipack_device_register -- register an IPack device with the kernel
* @dev: the new device to register.
* ipack_device_init -- initialize an IPack device
* @dev: the new device to initialize.
*
* Register a new IPack device ("module" in IndustryPack jargon). The call
* is done by the carrier driver. The carrier should populate the fields
* bus and slot as well as the region array of @dev prior to calling this
* function. The rest of the fields will be allocated and populated
* during registration.
* Initialize a new IPack device ("module" in IndustryPack jargon). The call
* is done by the carrier driver. The carrier should populate the fields
* bus and slot as well as the region array of @dev prior to calling this
* function. The rest of the fields will be allocated and populated
* during initalization.
*
* Return zero on success or error code on failure.
* Return zero on success or error code on failure.
*
* NOTE: _Never_ directly free @dev after calling this function, even
* if it returned an error! Always use ipack_put_device() to give up the
* reference initialized in this function instead.
*/
int ipack_device_register(struct ipack_device *dev);
void ipack_device_unregister(struct ipack_device *dev);
int ipack_device_init(struct ipack_device *dev);
/**
* ipack_device_add -- Add an IPack device
* @dev: the new device to add.
*
* Add a new IPack device. The call is done by the carrier driver
* after calling ipack_device_init().
*
* Return zero on success or error code on failure.
*
* NOTE: _Never_ directly free @dev after calling this function, even
* if it returned an error! Always use ipack_put_device() to give up the
* reference initialized in this function instead.
*/
int ipack_device_add(struct ipack_device *dev);
void ipack_device_del(struct ipack_device *dev);
void ipack_get_device(struct ipack_device *dev);
void ipack_put_device(struct ipack_device *dev);