mirror of
https://github.com/Fishwaldo/linux-bl808.git
synced 2025-06-17 20:25:19 +00:00
93e3f45a26
Commit 1e688dd2a3 ("powerpc/bug: Provide better flexibility to
WARN_ON/__WARN_FLAGS() with asm goto") updated __WARN_FLAGS() to use asm
goto, and added a call to 'unreachable()' after the asm goto for optimal
code generation. With CONFIG_OBJTOOL enabled, 'annotate_unreachable()'
statement in 'unreachable()' tries to note down the location of the
subsequent instruction in a separate elf section to aid code flow
analysis. However, on powerpc, this results in gcc emitting a call to a
symbol of size 0. This results in objtool complaining of "unannotated
intra-function call" since the target symbol is not a valid function
call destination.
Objtool wants this annotation for code flow analysis, which we are not
yet enabling on powerpc. As such, expand the call to 'unreachable()' in
__WARN_FLAGS() without annotate_unreachable():
barrier_before_unreachable();
__builtin_unreachable();
This still results in optimal code generation for __WARN_FLAGS(), while
getting rid of the objtool warning.
We still need barrier_before_unreachable() to work around gcc bugs 82365
and 106751:
- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82365
- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106751
Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Reviewed-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221114175754.1131267-2-sv@linux.ibm.com
176 lines
4.2 KiB
C
176 lines
4.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_POWERPC_BUG_H
|
|
#define _ASM_POWERPC_BUG_H
|
|
#ifdef __KERNEL__
|
|
|
|
#include <asm/asm-compat.h>
|
|
#include <asm/extable.h>
|
|
|
|
#ifdef CONFIG_BUG
|
|
|
|
#ifdef __ASSEMBLY__
|
|
#include <asm/asm-offsets.h>
|
|
#ifdef CONFIG_DEBUG_BUGVERBOSE
|
|
.macro __EMIT_BUG_ENTRY addr,file,line,flags
|
|
.section __bug_table,"aw"
|
|
5001: .4byte \addr - .
|
|
.4byte 5002f - .
|
|
.short \line, \flags
|
|
.org 5001b+BUG_ENTRY_SIZE
|
|
.previous
|
|
.section .rodata,"a"
|
|
5002: .asciz "\file"
|
|
.previous
|
|
.endm
|
|
#else
|
|
.macro __EMIT_BUG_ENTRY addr,file,line,flags
|
|
.section __bug_table,"aw"
|
|
5001: .4byte \addr - .
|
|
.short \flags
|
|
.org 5001b+BUG_ENTRY_SIZE
|
|
.previous
|
|
.endm
|
|
#endif /* verbose */
|
|
|
|
.macro EMIT_WARN_ENTRY addr,file,line,flags
|
|
EX_TABLE(\addr,\addr+4)
|
|
__EMIT_BUG_ENTRY \addr,\file,\line,\flags
|
|
.endm
|
|
|
|
.macro EMIT_BUG_ENTRY addr,file,line,flags
|
|
.if \flags & 1 /* BUGFLAG_WARNING */
|
|
.err /* Use EMIT_WARN_ENTRY for warnings */
|
|
.endif
|
|
__EMIT_BUG_ENTRY \addr,\file,\line,\flags
|
|
.endm
|
|
|
|
#else /* !__ASSEMBLY__ */
|
|
/* _EMIT_BUG_ENTRY expects args %0,%1,%2,%3 to be FILE, LINE, flags and
|
|
sizeof(struct bug_entry), respectively */
|
|
#ifdef CONFIG_DEBUG_BUGVERBOSE
|
|
#define _EMIT_BUG_ENTRY \
|
|
".section __bug_table,\"aw\"\n" \
|
|
"2: .4byte 1b - .\n" \
|
|
" .4byte %0 - .\n" \
|
|
" .short %1, %2\n" \
|
|
".org 2b+%3\n" \
|
|
".previous\n"
|
|
#else
|
|
#define _EMIT_BUG_ENTRY \
|
|
".section __bug_table,\"aw\"\n" \
|
|
"2: .4byte 1b - .\n" \
|
|
" .short %2\n" \
|
|
".org 2b+%3\n" \
|
|
".previous\n"
|
|
#endif
|
|
|
|
#define BUG_ENTRY(insn, flags, ...) \
|
|
__asm__ __volatile__( \
|
|
"1: " insn "\n" \
|
|
_EMIT_BUG_ENTRY \
|
|
: : "i" (__FILE__), "i" (__LINE__), \
|
|
"i" (flags), \
|
|
"i" (sizeof(struct bug_entry)), \
|
|
##__VA_ARGS__)
|
|
|
|
#define WARN_ENTRY(insn, flags, label, ...) \
|
|
asm_volatile_goto( \
|
|
"1: " insn "\n" \
|
|
EX_TABLE(1b, %l[label]) \
|
|
_EMIT_BUG_ENTRY \
|
|
: : "i" (__FILE__), "i" (__LINE__), \
|
|
"i" (flags), \
|
|
"i" (sizeof(struct bug_entry)), \
|
|
##__VA_ARGS__ : : label)
|
|
|
|
/*
|
|
* BUG_ON() and WARN_ON() do their best to cooperate with compile-time
|
|
* optimisations. However depending on the complexity of the condition
|
|
* some compiler versions may not produce optimal results.
|
|
*/
|
|
|
|
#define BUG() do { \
|
|
BUG_ENTRY("twi 31, 0, 0", 0); \
|
|
unreachable(); \
|
|
} while (0)
|
|
#define HAVE_ARCH_BUG
|
|
|
|
#define __WARN_FLAGS(flags) do { \
|
|
__label__ __label_warn_on; \
|
|
\
|
|
WARN_ENTRY("twi 31, 0, 0", BUGFLAG_WARNING | (flags), __label_warn_on); \
|
|
barrier_before_unreachable(); \
|
|
__builtin_unreachable(); \
|
|
\
|
|
__label_warn_on: \
|
|
break; \
|
|
} while (0)
|
|
|
|
#ifdef CONFIG_PPC64
|
|
#define BUG_ON(x) do { \
|
|
if (__builtin_constant_p(x)) { \
|
|
if (x) \
|
|
BUG(); \
|
|
} else { \
|
|
BUG_ENTRY(PPC_TLNEI " %4, 0", 0, "r" ((__force long)(x))); \
|
|
} \
|
|
} while (0)
|
|
|
|
#define WARN_ON(x) ({ \
|
|
bool __ret_warn_on = false; \
|
|
do { \
|
|
if (__builtin_constant_p((x))) { \
|
|
if (!(x)) \
|
|
break; \
|
|
__WARN(); \
|
|
__ret_warn_on = true; \
|
|
} else { \
|
|
__label__ __label_warn_on; \
|
|
\
|
|
WARN_ENTRY(PPC_TLNEI " %4, 0", \
|
|
BUGFLAG_WARNING | BUGFLAG_TAINT(TAINT_WARN), \
|
|
__label_warn_on, \
|
|
"r" ((__force long)(x))); \
|
|
break; \
|
|
__label_warn_on: \
|
|
__ret_warn_on = true; \
|
|
} \
|
|
} while (0); \
|
|
unlikely(__ret_warn_on); \
|
|
})
|
|
|
|
#define HAVE_ARCH_BUG_ON
|
|
#define HAVE_ARCH_WARN_ON
|
|
#endif
|
|
|
|
#endif /* __ASSEMBLY __ */
|
|
#else
|
|
#ifdef __ASSEMBLY__
|
|
.macro EMIT_BUG_ENTRY addr,file,line,flags
|
|
.endm
|
|
.macro EMIT_WARN_ENTRY addr,file,line,flags
|
|
.endm
|
|
#else /* !__ASSEMBLY__ */
|
|
#define _EMIT_BUG_ENTRY
|
|
#define _EMIT_WARN_ENTRY
|
|
#endif
|
|
#endif /* CONFIG_BUG */
|
|
|
|
#include <asm-generic/bug.h>
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
struct pt_regs;
|
|
void hash__do_page_fault(struct pt_regs *);
|
|
void bad_page_fault(struct pt_regs *, int);
|
|
extern void _exception(int, struct pt_regs *, int, unsigned long);
|
|
extern void _exception_pkey(struct pt_regs *, unsigned long, int);
|
|
extern void die(const char *, struct pt_regs *, long);
|
|
void die_mce(const char *str, struct pt_regs *regs, long err);
|
|
extern bool die_will_crash(void);
|
|
extern void panic_flush_kmsg_start(void);
|
|
extern void panic_flush_kmsg_end(void);
|
|
#endif /* !__ASSEMBLY__ */
|
|
|
|
#endif /* __KERNEL__ */
|
|
#endif /* _ASM_POWERPC_BUG_H */
|