Linus Torvalds 94c13f66e1 security: don't use a negative Opt_err token index ... The code uses a bitmap to check for duplicate tokens during parsing, and that doesn't work at all for the negative Opt_err token case. There is absolutely no reason to make Opt_err be negative, and in fact it only confuses things, since some of the affected functions actually return a positive Opt_xyz enum _or_ a regular negative error code (eg -EINVAL), and using -1 for Opt_err makes no sense. There are similar problems in ima_policy.c and key encryption, but they don't have the immediate bug wrt bitmap handing, and ima_policy.c in particular needs a different patch to make the enum values match the token array index. Mimi is sending that separately. Reported-by: syzbot+a22e0dc07567662c50bc@syzkaller.appspotmail.com Reported-by: Eric Biggers <ebiggers@kernel.org> Fixes: 5208cc8342 ("keys, trusted: fix: *do not* allow duplicate key options") Fixes: 00d60fd3b9 ("KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]") Cc: James Morris James Morris <jmorris@namei.org> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-12-17 16:21:48 -08:00
..
encrypted-keys
big_key.c	big key: get rid of stack array allocation	2018-05-11 13:07:45 -07:00
compat.c	KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]	2018-10-26 09:30:46 +01:00
compat_dh.c
dh.c	Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"	2018-09-25 13:28:58 +02:00
gc.c
internal.h	KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]	2018-10-26 09:30:46 +01:00
Kconfig
key.c	security: keys: remove redundant assignment to key_ref	2017-12-08 15:13:29 +00:00
keyctl.c	KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]	2018-10-26 09:30:46 +01:00
keyctl_pkey.c	security: don't use a negative Opt_err token index	2018-12-17 16:21:48 -08:00
keyring.c
Makefile	KEYS: Provide keyctls to drive the new key type ops for asymmetric keys [ver #2]	2018-10-26 09:30:46 +01:00
permission.c
persistent.c
proc.c	proc: introduce proc_create_seq{,_data}	2018-05-16 07:23:35 +02:00
process_keys.c
request_key.c
request_key_auth.c
sysctl.c
trusted.c	security: don't use a negative Opt_err token index	2018-12-17 16:21:48 -08:00
user_defined.c