Teng Qi 0fa68da72c net: ethernet: dec: tulip: de4x5: fix possible array overflows in type3_infoblock() ... The definition of macro MOTO_SROM_BUG is: #define MOTO_SROM_BUG (lp->active == 8 && (get_unaligned_le32( dev->dev_addr) & 0x00ffffff) == 0x3e0008) and the if statement if (MOTO_SROM_BUG) lp->active = 0; using this macro indicates lp->active could be 8. If lp->active is 8 and the second comparison of this macro is false. lp->active will remain 8 in: lp->phy[lp->active].gep = (*p ? p : NULL); p += (2 * (*p) + 1); lp->phy[lp->active].rst = (*p ? p : NULL); p += (2 * (*p) + 1); lp->phy[lp->active].mc = get_unaligned_le16(p); p += 2; lp->phy[lp->active].ana = get_unaligned_le16(p); p += 2; lp->phy[lp->active].fdx = get_unaligned_le16(p); p += 2; lp->phy[lp->active].ttm = get_unaligned_le16(p); p += 2; lp->phy[lp->active].mci = *p; However, the length of array lp->phy is 8, so array overflows can occur. To fix these possible array overflows, we first check lp->active and then return -EINVAL if it is greater or equal to ARRAY_SIZE(lp->phy) (i.e. 8). Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Teng Qi <starmiku1207184332@gmail.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: David S. Miller <davem@davemloft.net>		2021-11-18 12:03:17 +00:00
..
21142.c
de4x5.c	net: ethernet: dec: tulip: de4x5: fix possible array overflows in type3_infoblock()	2021-11-18 12:03:17 +00:00
de4x5.h
de2104x.c	tulip: fix setting device address from rom	2021-10-12 11:29:16 +01:00
dmfe.c	tulip: fix setting device address from rom	2021-10-12 11:29:16 +01:00
eeprom.c
interrupt.c
Kconfig
Makefile
media.c
pnic.c
pnic2.c
timer.c
tulip.h
tulip_core.c	ethernet: tulip: avoid duplicate variable name on sparc	2021-10-12 12:12:13 +01:00
uli526x.c
winbond-840.c	net: tulip: winbond-840: fix build for UML	2021-10-14 19:18:53 -07:00
xircom_cb.c