Mike Snitzer f62b6b8f49 dm space map metadata: return on failure in sm_metadata_new_block ... Commit 2fc48021f4 ("dm persistent metadata: add space map threshold callback") introduced a regression to the metadata block allocation path that resulted in errors being ignored. This regression was uncovered by running the following device-mapper-test-suite test: dmtest run --suite thin-provisioning -n /exhausting_metadata_space_causes_fail_mode/ The ignored error codes in sm_metadata_new_block() could crash the kernel through use of either the dm-thin or dm-cache targets, e.g.: device-mapper: thin: 253:4: reached low water mark for metadata device: sending event. device-mapper: space map metadata: unable to allocate new metadata block general protection fault: 0000 [#1] SMP ... Workqueue: dm-thin do_worker [dm_thin_pool] task: ffff880035ce2ab0 ti: ffff88021a054000 task.ti: ffff88021a054000 RIP: 0010:[<ffffffffa0331385>] [<ffffffffa0331385>] metadata_ll_load_ie+0x15/0x30 [dm_persistent_data] RSP: 0018:ffff88021a055a68 EFLAGS: 00010202 RAX: 003fc8243d212ba0 RBX: ffff88021a780070 RCX: ffff88021a055a78 RDX: ffff88021a055a78 RSI: 0040402222a92a80 RDI: ffff88021a780070 RBP: ffff88021a055a68 R08: ffff88021a055ba4 R09: 0000000000000010 R10: 0000000000000000 R11: 00000002a02e1000 R12: ffff88021a055ad4 R13: 0000000000000598 R14: ffffffffa0338470 R15: ffff88021a055ba4 FS: 0000000000000000(0000) GS:ffff88033fca0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 00007f467c0291b8 CR3: 0000000001a0b000 CR4: 00000000000007e0 Stack: ffff88021a055ab8 ffffffffa0332020 ffff88021a055b30 0000000000000001 ffff88021a055b30 0000000000000000 ffff88021a055b18 0000000000000000 ffff88021a055ba4 ffff88021a055b98 ffff88021a055ae8 ffffffffa033304c Call Trace: [<ffffffffa0332020>] sm_ll_lookup_bitmap+0x40/0xa0 [dm_persistent_data] [<ffffffffa033304c>] sm_metadata_count_is_more_than_one+0x8c/0xc0 [dm_persistent_data] [<ffffffffa0333825>] dm_tm_shadow_block+0x65/0x110 [dm_persistent_data] [<ffffffffa0331b00>] sm_ll_mutate+0x80/0x300 [dm_persistent_data] [<ffffffffa0330e60>] ? set_ref_count+0x10/0x10 [dm_persistent_data] [<ffffffffa0331dba>] sm_ll_inc+0x1a/0x20 [dm_persistent_data] [<ffffffffa0332270>] sm_disk_new_block+0x60/0x80 [dm_persistent_data] [<ffffffff81520036>] ? down_write+0x16/0x40 [<ffffffffa001e5c4>] dm_pool_alloc_data_block+0x54/0x80 [dm_thin_pool] [<ffffffffa001b23c>] alloc_data_block+0x9c/0x130 [dm_thin_pool] [<ffffffffa001c27e>] provision_block+0x4e/0x180 [dm_thin_pool] [<ffffffffa001fe9a>] ? dm_thin_find_block+0x6a/0x110 [dm_thin_pool] [<ffffffffa001c57a>] process_bio+0x1ca/0x1f0 [dm_thin_pool] [<ffffffff8111e2ed>] ? mempool_free+0x8d/0xa0 [<ffffffffa001d755>] process_deferred_bios+0xc5/0x230 [dm_thin_pool] [<ffffffffa001d911>] do_worker+0x51/0x60 [dm_thin_pool] [<ffffffff81067872>] process_one_work+0x182/0x3b0 [<ffffffff81068c90>] worker_thread+0x120/0x3a0 [<ffffffff81068b70>] ? manage_workers+0x160/0x160 [<ffffffff8106eb2e>] kthread+0xce/0xe0 [<ffffffff8106ea60>] ? kthread_freezable_should_stop+0x70/0x70 [<ffffffff8152af6c>] ret_from_fork+0x7c/0xb0 [<ffffffff8106ea60>] ? kthread_freezable_should_stop+0x70/0x70 [<ffffffff8152af6c>] ret_from_fork+0x7c/0xb0 [<ffffffff8106ea60>] ? kthread_freezable_should_stop+0x70/0x70 Signed-off-by: Mike Snitzer <snitzer@redhat.com> Acked-by: Joe Thornber <ejt@redhat.com> Cc: stable@vger.kernel.org # v3.10+		2013-12-10 16:34:28 -05:00
..
dm-array.c	dm array: fix bug in growing array	2013-11-05 11:20:50 -05:00
dm-array.h	dm persistent data: add transactional array	2013-03-01 22:45:51 +00:00
dm-bitset.c	dm persistent data: add bitset	2013-03-01 22:45:51 +00:00
dm-bitset.h	dm persistent data: add bitset	2013-03-01 22:45:51 +00:00
dm-block-manager.c	dm btree: prefetch child nodes when walking tree for a dm_btree_del	2013-08-23 09:02:14 -04:00
dm-block-manager.h	dm btree: prefetch child nodes when walking tree for a dm_btree_del	2013-08-23 09:02:14 -04:00
dm-btree-internal.h	dm persistent data: add btree_walk	2013-03-01 22:45:50 +00:00
dm-btree-remove.c	dm thin: fix discard corruption	2013-03-20 17:21:24 +00:00
dm-btree-spine.c	dm persistent data: add btree_walk	2013-03-01 22:45:50 +00:00
dm-btree.c	dm btree: prefetch child nodes when walking tree for a dm_btree_del	2013-08-23 09:02:14 -04:00
dm-btree.h	dm persistent data: add btree_walk	2013-03-01 22:45:50 +00:00
dm-persistent-data-internal.h
dm-space-map-common.c	dm space map: optimise sm_ll_dec and sm_ll_inc	2013-08-23 09:02:14 -04:00
dm-space-map-common.h	dm persistent data: only commit space map if index changed	2012-07-27 15:08:06 +01:00
dm-space-map-disk.c	dm space map disk: optimise sm_disk_dec_block	2013-11-09 18:20:24 -05:00
dm-space-map-disk.h
dm-space-map-metadata.c	dm space map metadata: return on failure in sm_metadata_new_block	2013-12-10 16:34:28 -05:00
dm-space-map-metadata.h
dm-space-map.h	dm persistent data: add threshold callback to space map	2013-05-10 14:37:20 +01:00
dm-transaction-manager.c	hlist: drop the node parameter from iterators	2013-02-27 19:10:24 -08:00
dm-transaction-manager.h	dm persistent data: tidy transaction manager creation fns	2012-07-27 15:08:09 +01:00
Kconfig	dm persistent data: remove CONFIG_EXPERIMENTAL	2013-03-01 22:45:46 +00:00
Makefile	dm persistent data: add bitset	2013-03-01 22:45:51 +00:00