GitHub-Mirror/open-zwave
2
0
Fork 0
mirror of https://github.com/Fishwaldo/open-zwave.git synced 2025-03-15 19:41:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Check for Invalid HomeID or Controller Node ID's

Browse source 
ModemManager on the Host is known to interfere with OZW, and cause problems when starting up. Users will often get messages about "Out of Frame Flow" in OZW_Log.txt. See https://github.com/home-assistant/home-assistant/issues/21165 for example. 

One of the more bizarre side effects of this, is that it causes issues with OZW initializing and a side effect is Node 255 (Broadcast) address will be added to all Associations on devices. This causes weird issues such as a switch triggering every Z-Wave Node in the network etc. 

This check will bail out if we receive a invalid HomeID or Controller Node ID when starting up and stop OZW from inadvertently adding this broadcast address to all node associations.
This commit is contained in:
Justin Hammond 2019-12-02 20:48:17 +08:00 • committed by GitHub
parent 8e89e6ec64
commit 649bc601f4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cpp/src/Driver.cpp
View file

@ -2642,6 +2642,15 @@ void Driver::HandleSerialAPIGetInitDataResponse
{
int32 i;
if (m_homeId == 0 || m_Controller_nodeId == -1) {
Log::Write(LogLevel_Fatal, "Failed to get HomeID or Controller Node ID during Init Sequence");
Notification* notification = new Notification(Notification::Type_DriverFailed);
QueueNotification(notification);
NotifyWatchers();
m_driverThread->Stop();
return;
}
if( !m_init )
{
// Mark the driver as ready (we have to do this first or