GitHub-Mirror/opensbi
2
0
Fork 0
mirror of https://github.com/Fishwaldo/opensbi.git synced 2025-07-04 12:08:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

firmware: Only default FW_PIC to y if supported

Browse source 
Bare-metal GNU ld does not support PIE, so if using it this will result
in a failure to build. Instead, default to FW_PIC=n if not supported.
Note that an explicit FW_PIC=y is not overridden, to ensure the build
fails rather than silently producing a position-dependent binary.

Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Anup Patel <anup.patel@wdc.com>
This commit is contained in:
Jessica Clarke 2021-07-11 03:28:22 +01:00 • committed by Anup Patel
parent a3d328ae33
commit 09ad811ec4
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Makefile
View file

@ -106,6 +106,9 @@ ifndef PLATFORM_RISCV_XLEN
endif endif
endif endif
# Check whether the linker supports creating PIEs
OPENSBI_LD_PIE := $(shell $(CC) -fPIE -nostdlib -Wl,-pie -x c /dev/null -o /dev/null >/dev/null 2>&1 && echo y || echo n)
# Setup list of objects.mk files # Setup list of objects.mk files
ifdef PLATFORM ifdef PLATFORM
platform-object-mks=$(shell if [ -d $(platform_src_dir)/ ]; then find $(platform_src_dir) -iname "objects.mk" | sort -r; fi) platform-object-mks=$(shell if [ -d $(platform_src_dir)/ ]; then find $(platform_src_dir) -iname "objects.mk" | sort -r; fi)

2
firmware/objects.mk
View file

@ -14,7 +14,7 @@ firmware-asflags-y +=
firmware-ldflags-y += firmware-ldflags-y +=
ifndef FW_PIC ifndef FW_PIC
FW_PIC := y FW_PIC := $(OPENSBI_LD_PIE)
endif endif
ifeq ($(FW_PIC),y) ifeq ($(FW_PIC),y)