From 6c24193293e7cc0854994d7551f32e31ebc06ff6 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Fri, 9 Aug 2019 17:14:00 -0600 Subject: [PATCH] lib: Correct null pointer check In order to prevent a possible null pointer dereference, return early if either one of 'in' or 'data' is null. Signed-off-by: Jacob Garber Reviewed-by: Bin Meng Reviewed-by: Atish Patra --- lib/sbi/sbi_tlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_tlb.c b/lib/sbi/sbi_tlb.c index cffda52..104c066 100644 --- a/lib/sbi/sbi_tlb.c +++ b/lib/sbi/sbi_tlb.c @@ -66,7 +66,7 @@ static int sbi_tlb_fifo_update_cb(void *in, void *data) struct sbi_tlb_info *next; int ret = SBI_FIFO_UNCHANGED; - if (!in && !!data) + if (!in || !data) return ret; curr = (struct sbi_tlb_info *)data;