GitHub-Mirror/opensbi
2
0
Fork 0
mirror of https://github.com/Fishwaldo/opensbi.git synced 2025-03-18 12:51:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

lib: utils/fdt: simplify dt_parse_isa_extensions

Browse source 
hart_exts == NULL can only occur if offset and node address lead to an
overflow resulting in exactly NULL. As we don't catch other values of
overflow it does not make sense to treat this one as special.

Addresses-Coverity-ID: 1568355 Logically dead code
Addresses-Coverity-ID: 1568358 Logically dead code
Fixes: 6259b2ec2d ("lib: utils/fdt: Fix fdt_parse_isa_extensions() implementation")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Heinrich Schuchardt 2023-09-27 16:19:12 +02:00 • committed by Anup Patel
parent 8197c2f1ec
commit 9da30f6105
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/utils/fdt/fdt_helper.c
View file

@ -417,8 +417,6 @@ static int fdt_parse_isa_all_harts(void *fdt)
hart_exts = sbi_scratch_offset_ptr(scratch,
fdt_isa_bitmap_offset);
if (!hart_exts)
return SBI_ENOENT;
err = fdt_parse_isa_one_hart((const char *)val, hart_exts);
if (err)
@ -452,8 +450,6 @@ int fdt_parse_isa_extensions(void *fdt, unsigned int hartid,
return SBI_ENOENT;
hart_exts = sbi_scratch_offset_ptr(scratch, fdt_isa_bitmap_offset);
if (!hart_exts)
return SBI_ENOENT;
for (i = 0; i < BITS_TO_LONGS(SBI_HART_EXT_MAX); i++)
extensions[i] |= hart_exts[i];