From dc0bb19bd2f969e8c2b8c55a71b3ae569eedfaf6 Mon Sep 17 00:00:00 2001 From: Xiang W Date: Fri, 17 Nov 2023 09:03:59 +0800 Subject: [PATCH] lib: utils/serial: remove semihosting_putc For some debuggers that do not implement SYSWRITEC and SYSREADC operations, we have to use SYSWRITE and SYSREAD. Instead of implementing semihosting_putc() using SYSWRITE, let us simply remove semihosting_putc() because console_putc/console_puts are now interchangeable. Signed-off-by: Chen Pei Signed-off-by: Xiang W Reviewed-by: Guo Ren Reviewed-by: Anup Patel --- lib/utils/serial/semihosting.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/utils/serial/semihosting.c b/lib/utils/serial/semihosting.c index a27c69e..19ebaa0 100644 --- a/lib/utils/serial/semihosting.c +++ b/lib/utils/serial/semihosting.c @@ -178,11 +178,6 @@ static unsigned long semihosting_puts(const char *str, unsigned long len) return (ret < 0) ? 0 : ret; } -static void semihosting_putc(char ch) -{ - semihosting_puts(&ch, 1); -} - static int semihosting_getc(void) { char ch = 0; @@ -199,7 +194,6 @@ static int semihosting_getc(void) static struct sbi_console_device semihosting_console = { .name = "semihosting", - .console_putc = semihosting_putc, .console_puts = semihosting_puts, .console_getc = semihosting_getc };