From 251a8f661e342e7df78162c9b6ee5a9ea8884eee Mon Sep 17 00:00:00 2001 From: Vincent Behar Date: Fri, 8 Jul 2011 14:39:03 +0200 Subject: [PATCH] fix typo in javadoc + format code --- .../rundeck/api/domain/RundeckExecution.java | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/src/main/java/org/rundeck/api/domain/RundeckExecution.java b/src/main/java/org/rundeck/api/domain/RundeckExecution.java index 7292646..4df8329 100644 --- a/src/main/java/org/rundeck/api/domain/RundeckExecution.java +++ b/src/main/java/org/rundeck/api/domain/RundeckExecution.java @@ -63,38 +63,29 @@ public class RundeckExecution implements Serializable { } /** - * @return the duration of the execution in seconds (or null if the duration is still running, or has been aborted) + * @return the duration of the execution in seconds (or null if the execution is still running, or has been aborted) */ public Long getDurationInSeconds() { Long durationInMillis = getDurationInMillis(); - if (durationInMillis == null) { - return null; - } - return TimeUnit.MILLISECONDS.toSeconds(durationInMillis); + return durationInMillis != null ? TimeUnit.MILLISECONDS.toSeconds(durationInMillis) : null; } /** * @return the duration of the execution, as a human-readable string : "3 minutes 34 seconds" (or null if the - * duration is still running, or has been aborted) + * execution is still running, or has been aborted) */ public String getDuration() { Long durationInMillis = getDurationInMillis(); - if (durationInMillis == null) { - return null; - } - return DurationFormatUtils.formatDurationWords(durationInMillis, true, true); + return durationInMillis != null ? DurationFormatUtils.formatDurationWords(durationInMillis, true, true) : null; } /** * @return the duration of the execution, as a "short" human-readable string : "0:03:34.187" (or null if the - * duration is still running, or has been aborted) + * execution is still running, or has been aborted) */ public String getShortDuration() { Long durationInMillis = getDurationInMillis(); - if (durationInMillis == null) { - return null; - } - return DurationFormatUtils.formatDurationHMS(durationInMillis); + return durationInMillis != null ? DurationFormatUtils.formatDurationHMS(durationInMillis) : null; } public Long getId() {