GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-03-20 22:21:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mtd: denali: fix NAND_CMD_PARAM command

Browse source 
NAND_CMD_PARAM (0xEC) command is not working on the Denali
NAND controller driver.

Unlike NAND_CMD_READID (0x90), when the NAND_CMD_PARAM command
is followed by an address cycle, the target device goes busy.
(R/B# is deasserted)
Wait until the parameter data are ready.

In addition, unnecessary clear_interrupts() should be removed.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Chin Liang See <clsee@altera.com>
This commit is contained in:
Masahiro Yamada 2014-10-03 20:03:03 +09:00 • committed by Scott Wood
parent dd0204e48d
commit 05968e7cfd
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/mtd/nand/denali.c
View file

@ -1059,9 +1059,8 @@ static void denali_cmdfunc(struct mtd_info *mtd, unsigned int cmd, int col,
addr = MODE_11 | BANK(denali->flash_bank); addr = MODE_11 | BANK(denali->flash_bank);
index_addr(denali, addr | 0, cmd); index_addr(denali, addr | 0, cmd);
break; break;
case NAND_CMD_PARAM:
clear_interrupts(denali);
case NAND_CMD_READID: case NAND_CMD_READID:
case NAND_CMD_PARAM:
reset_buf(denali); reset_buf(denali);
/* sometimes ManufactureId read from register is not right /* sometimes ManufactureId read from register is not right
* e.g. some of Micron MT29F32G08QAA MLC NAND chips * e.g. some of Micron MT29F32G08QAA MLC NAND chips
@ -1070,6 +1069,8 @@ static void denali_cmdfunc(struct mtd_info *mtd, unsigned int cmd, int col,
addr = MODE_11 | BANK(denali->flash_bank); addr = MODE_11 | BANK(denali->flash_bank);
index_addr(denali, addr | 0, cmd); index_addr(denali, addr | 0, cmd);
index_addr(denali, addr | 1, col & 0xFF); index_addr(denali, addr | 1, col & 0xFF);
if (cmd == NAND_CMD_PARAM)
udelay(50);
break; break;
case NAND_CMD_READ0: case NAND_CMD_READ0:
case NAND_CMD_SEQIN: case NAND_CMD_SEQIN: