GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-06-07 15:21:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

dm: gpio: vybrid_gpio: Correct driver's use of bind() method

Browse source 
It does not look like this driver needs to use a bind() method. It does
not manually create devices with device_bind() nor does it create devices
using U_BOOT_DEVICE(). It seems to only use device tree.

Therefore the manual allocation of platform data is not needed and is
confusing. Also platform data should be set up by the ofdata_to_platdata()
method, not bind().

Update the driver in case others use it as a model in future.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Adam Ford <aford173@gmail.com>
This commit is contained in:
Simon Glass 2017-09-17 16:54:51 -06:00
parent 085391b223
commit 1ba214767d
1 changed files with 6 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
drivers/gpio/vybrid_gpio.c
View file

@ -105,32 +105,18 @@ static int vybrid_gpio_probe(struct udevice *dev)
return 0; return 0;
} }
static int vybrid_gpio_bind(struct udevice *dev) static int vybrid_gpio_odata_to_platdata(struct udevice *dev)
{ {
struct vybrid_gpio_platdata *plat = dev->platdata; struct vybrid_gpio_platdata *plat = dev_get_platdata(dev);
fdt_addr_t base_addr; fdt_addr_t base_addr;
if (plat)
return 0;
base_addr = devfdt_get_addr(dev); base_addr = devfdt_get_addr(dev);
if (base_addr == FDT_ADDR_T_NONE) if (base_addr == FDT_ADDR_T_NONE)
return -ENODEV; return -EINVAL;
/*
* TODO:
* When every board is converted to driver model and DT is
* supported, this can be done by auto-alloc feature, but
* not using calloc to alloc memory for platdata.
*/
plat = calloc(1, sizeof(*plat));
if (!plat)
return -ENOMEM;
plat->base = base_addr; plat->base = base_addr;
plat->chip = dev->req_seq; plat->chip = dev->req_seq;
plat->port_name = fdt_get_name(gd->fdt_blob, dev_of_offset(dev), NULL); plat->port_name = fdt_get_name(gd->fdt_blob, dev_of_offset(dev), NULL);
dev->platdata = plat;
return 0; return 0;
} }
@ -144,8 +130,9 @@ U_BOOT_DRIVER(gpio_vybrid) = {
.name = "gpio_vybrid", .name = "gpio_vybrid",
.id = UCLASS_GPIO, .id = UCLASS_GPIO,
.ops = &gpio_vybrid_ops, .ops = &gpio_vybrid_ops,
.of_match = vybrid_gpio_ids,
.ofdata_to_platdata = vybrid_gpio_odata_to_platdata,
.probe = vybrid_gpio_probe, .probe = vybrid_gpio_probe,
.priv_auto_alloc_size = sizeof(struct vybrid_gpios), .priv_auto_alloc_size = sizeof(struct vybrid_gpios),
.of_match = vybrid_gpio_ids, .platdata_auto_alloc_size = sizeof(struct vybrid_gpio_platdata),
.bind = vybrid_gpio_bind,
}; };