GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-04-03 13:01:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

efi_loader: check device path in InstallMultipleProtocolInterfaces

Browse source 
According to the UEFI spec InstallMultipleProtocolInterfaces() must check
if a device path has already been installed. In this case it must return
EFI_ALREADY_STARTED.

Cf. UEFI SCT II 2.6 A (2017),
3.3.16 InstallMultipleProtocolInterfaces(), 5.1.3.16.1.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2019-05-16 21:54:04 +02:00
parent b1b782d306
commit 226cddbe32
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/efi_loader/efi_boottime.c
View file

@ -2334,6 +2334,7 @@ efi_status_t EFIAPI efi_install_multiple_protocol_interfaces
efi_va_list argptr; efi_va_list argptr;
const efi_guid_t *protocol; const efi_guid_t *protocol;
void *protocol_interface; void *protocol_interface;
efi_handle_t old_handle;
efi_status_t r = EFI_SUCCESS; efi_status_t r = EFI_SUCCESS;
int i = 0; int i = 0;
@ -2346,6 +2347,17 @@ efi_status_t EFIAPI efi_install_multiple_protocol_interfaces
if (!protocol) if (!protocol)
break; break;
protocol_interface = efi_va_arg(argptr, void*); protocol_interface = efi_va_arg(argptr, void*);
/* Check that a device path has not been installed before */
if (!guidcmp(protocol, &efi_guid_device_path)) {
struct efi_device_path *dp = protocol_interface;
r = EFI_CALL(efi_locate_device_path(protocol, &dp,
&old_handle));
if (r == EFI_SUCCESS) {
r = EFI_ALREADY_STARTED;
break;
}
}
r = EFI_CALL(efi_install_protocol_interface( r = EFI_CALL(efi_install_protocol_interface(
handle, protocol, handle, protocol,
EFI_NATIVE_INTERFACE, EFI_NATIVE_INTERFACE,