GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-06-28 09:31:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "image-fit: Fix signature checking"

Browse source 
This reverts commit 84ca65aa4b.

On signature verification failures fit_image_verify() should NOT exit with
error. Only keys marked 'required' can cause image verification failure.
This logic is already there and works correctly.

Add a comment to make this clear.

Fixes: 84ca65aa (image-fit: Fix signature checking)
Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2016-02-24 09:14:43 -07:00
parent 7a80de4641
commit 2e33e76165
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
common/image-fit.c
View file

@ -1035,10 +1035,15 @@ int fit_image_verify(const void *fit, int image_noffset)
strlen(FIT_SIG_NODENAME))) { strlen(FIT_SIG_NODENAME))) {
ret = fit_image_check_sig(fit, noffset, data, ret = fit_image_check_sig(fit, noffset, data,
size, -1, &err_msg); size, -1, &err_msg);
if (ret) {
/*
* Show an indication on failure, but do not return
* an error. Only keys marked 'required' can cause
* an image validation failure. See the call to
* fit_image_verify_required_sigs() above.
*/
if (ret)
puts("- "); puts("- ");
goto error;
}
else else
puts("+ "); puts("+ ");
} }