GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-03-21 06:31:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

bedbug_860.c, bedbug_603e.c: Fix return type to silence compile warnings.

Browse source 
commit 47e26b1b "cmd_usage(): simplify return code handling" caused
the following compile warnings:

bedbug_860.c: In function 'bedbug860_do_break':
bedbug_860.c:73: warning: 'return' with a value, in function returning void
bedbug_860.c:121: warning: 'return' with a value, in function returning void

Fix the return type.

Actually these files could need some cleanup - commands should
return proper error codes, and there are coding style issues.
=> To be fixed later.

Signed-off-by: Wolfgang Denk <wd@denx.de>
This commit is contained in:
Wolfgang Denk 2010-08-19 00:27:33 +02:00
parent 2df0e6fc6b
commit 40e74c852b
2 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
arch/powerpc/cpu/mpc8260/bedbug_603e.c
View file

@ -70,8 +70,10 @@ void bedbug603e_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
int which_bp; /* Breakpoint number */
/* -------------------------------------------------- */
if (argc < 2)
return cmd_usage(cmdtp);
if (argc < 2) {
cmd_usage(cmdtp);
return;
}
/* Turn off a breakpoint */
@ -114,8 +116,10 @@ void bedbug603e_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
if(!(( isdigit( argv[ 1 ][ 0 ] )) ||
(( argv[ 1 ][ 0 ] >= 'a' ) && ( argv[ 1 ][ 0 ] <= 'f' )) ||
(( argv[ 1 ][ 0 ] >= 'A' ) && ( argv[ 1 ][ 0 ] <= 'F' ))))
return cmd_usage(cmdtp);
(( argv[ 1 ][ 0 ] >= 'A' ) && ( argv[ 1 ][ 0 ] <= 'F' )))) {
cmd_usage(cmdtp);
return;
}
addr = simple_strtoul( argv[ 1 ], NULL, 16 );

12
arch/powerpc/cpu/mpc8xx/bedbug_860.c
View file

@ -69,8 +69,10 @@ void bedbug860_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
int which_bp; /* Breakpoint number */
/* -------------------------------------------------- */
if (argc < 2)
return cmd_usage(cmdtp);
if (argc < 2) {
cmd_usage(cmdtp);
return;
}
/* Turn off a breakpoint */
@ -117,8 +119,10 @@ void bedbug860_do_break (cmd_tbl_t *cmdtp, int flag, int argc,
/* Set a breakpoint at the address */
if( !isdigit( argv[ 1 ][ 0 ]))
return cmd_usage(cmdtp);
if( !isdigit( argv[ 1 ][ 0 ])) {
cmd_usage(cmdtp);
return;
}
addr = simple_strtoul( argv[ 1 ], NULL, 16 ) & 0xfffffffc;