From 02325c7bfd7ccafae600774273f1b8ac11e90c08 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Sat, 7 Apr 2018 18:06:27 -0300 Subject: [PATCH 1/2] treewide: fix up files incorrectly marked executable Inspired by the following kernel commit: "commit 90fda63fa1156ec1bcfd7f9ca384cec221f70a21 Author: Linus Torvalds Date: Sat Apr 7 13:31:23 2018 -0700 treewide: fix up files incorrectly marked executable Joe Perches noted that we have a few source files that for some inexplicable reason (read: I'm too lazy to even go look at the history) are marked executable: drivers/gpu/drm/amd/amdgpu/vce_v4_0.c drivers/net/ethernet/cadence/macb_ptp.c A simple git command line to show executable C/asm/header files is this: git ls-files -s '*.[chsS]' | grep '^100755' and then you can fix them up with scripting by just feeding that output into: | cut -f2 | xargs chmod -x and commit it. Which is exactly what this commit does. Reported-by: Joe Perches Signed-off-by: Linus Torvalds " Do the same in the U-Boot source tree. Signed-off-by: Fabio Estevam --- drivers/video/anx9804.c | 0 include/configs/blanche.h | 0 2 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/video/anx9804.c mode change 100755 => 100644 include/configs/blanche.h diff --git a/drivers/video/anx9804.c b/drivers/video/anx9804.c old mode 100755 new mode 100644 diff --git a/include/configs/blanche.h b/include/configs/blanche.h old mode 100755 new mode 100644 From 751641814c1db245695dd8f40e9c811320e69f79 Mon Sep 17 00:00:00 2001 From: Tom Rini Date: Sun, 22 Apr 2018 09:47:48 -0400 Subject: [PATCH 2/2] video-uclass: Fix logical-not-parentheses warning With clang-4.0 and later we see: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if ((!gd->flags & GD_FLG_RELOC)) ^ ~ And while the compiler suggests adding parenthesis around gd->flags, a reading of the code says that we want to know when GD_FLG_RELOC is not set and then return. Cc: Simon Glass Cc: Anatolij Gustschin Signed-off-by: Tom Rini --- drivers/video/video-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index b5bb8e0efd..93fdc6828b 100644 --- a/drivers/video/video-uclass.c +++ b/drivers/video/video-uclass.c @@ -272,7 +272,7 @@ static int video_post_bind(struct udevice *dev) ulong size; /* Before relocation there is nothing to do here */ - if ((!gd->flags & GD_FLG_RELOC)) + if (!(gd->flags & GD_FLG_RELOC)) return 0; size = alloc_fb(dev, &addr); if (addr < gd->video_bottom) {