GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-03-19 05:31:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

net: pfe_eth: Fix resoure leak in pfe_spi_flash_init

Browse source 
Fix Coverity issue: RESOURCE_LEAK.
leaked_storage: Variable addr going out of scope leaks the storage it
points to.

Fixes: e0152dbed6 ("net: pfe_eth: Use spi_flash_read API to access
flash memory")
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
This commit is contained in:
Kuldeep Singh 2020-09-11 16:36:48 +05:30 • committed by Priyanka Jain
parent 450d491293
commit 63d5344615
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/pfe_eth/pfe_firmware.c
View file

@ -170,6 +170,9 @@ int pfe_spi_flash_init(void)
int ret = 0; int ret = 0;
void *addr = malloc(CONFIG_SYS_QE_FMAN_FW_LENGTH); void *addr = malloc(CONFIG_SYS_QE_FMAN_FW_LENGTH);
if (!addr)
return -ENOMEM;
#ifdef CONFIG_DM_SPI_FLASH #ifdef CONFIG_DM_SPI_FLASH
struct udevice *new; struct udevice *new;
@ -186,6 +189,7 @@ int pfe_spi_flash_init(void)
#endif #endif
if (!pfe_flash) { if (!pfe_flash) {
printf("SF: probe for pfe failed\n"); printf("SF: probe for pfe failed\n");
free(addr);
return -ENODEV; return -ENODEV;
} }