GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-04-03 04:51:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mmc: mmc_spi: Move argument check to the beginning of mmc_spi_sendcmd()

Browse source 
The argument check should happen before any transfer on the SPI lines.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
This commit is contained in:
Bin Meng 2021-02-02 10:48:46 +08:00 • committed by Peng Fan
parent 01962f8d7c
commit 781aad0de9
1 changed files with 3 additions and 3 deletions

6
drivers/mmc/mmc_spi.c
View file

@ -78,6 +78,9 @@ static int mmc_spi_sendcmd(struct udevice *dev,
int i, rpos = 0, ret = 0; int i, rpos = 0, ret = 0;
u8 cmdo[7], r; u8 cmdo[7], r;
if (!resp || !resp_size)
return 0;
debug("%s: cmd%d cmdarg=0x%x resp_type=0x%x " debug("%s: cmd%d cmdarg=0x%x resp_type=0x%x "
"resp_size=%d resp_match=%d resp_match_value=0x%x\n", "resp_size=%d resp_match=%d resp_match_value=0x%x\n",
__func__, cmdidx, cmdarg, resp_type, __func__, cmdidx, cmdarg, resp_type,
@ -98,9 +101,6 @@ static int mmc_spi_sendcmd(struct udevice *dev,
if (ret) if (ret)
return ret; return ret;
if (!resp || !resp_size)
return 0;
debug("%s: cmd%d", __func__, cmdidx); debug("%s: cmd%d", __func__, cmdidx);
if (resp_match) { if (resp_match) {