GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-03-20 22:21:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

efi_loader: parameter checks EFI_FILE_PROTOCOL.SetInfo()

Browse source 
We do not support volume label changes. No parameter checks are needed
here.

When the info for as file is changed the buffer must always contain a file
name.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2019-09-08 11:37:07 +02:00
parent 11335c0439
commit 8262578535
1 changed files with 4 additions and 6 deletions

10
lib/efi_loader/efi_file.c
View file

@ -695,7 +695,9 @@ static efi_status_t EFIAPI efi_file_setinfo(struct efi_file_handle *file,
char *new_file_name, *pos; char *new_file_name, *pos;
loff_t file_size; loff_t file_size;
if (buffer_size < sizeof(struct efi_file_info)) { /* The buffer will always contain a file name. */
if (buffer_size < sizeof(struct efi_file_info) + 2 ||
buffer_size < info->size) {
ret = EFI_BAD_BUFFER_SIZE; ret = EFI_BAD_BUFFER_SIZE;
goto out; goto out;
} }
@ -735,12 +737,8 @@ static efi_status_t EFIAPI efi_file_setinfo(struct efi_file_handle *file,
* TODO: Support read only * TODO: Support read only
*/ */
ret = EFI_SUCCESS; ret = EFI_SUCCESS;
} else if (!guidcmp(info_type, &efi_file_system_info_guid)) {
if (buffer_size < sizeof(struct efi_file_system_info)) {
ret = EFI_BAD_BUFFER_SIZE;
goto out;
}
} else { } else {
/* TODO: We do not support changing the volume label */
ret = EFI_UNSUPPORTED; ret = EFI_UNSUPPORTED;
} }
out: out: