mirror of
https://github.com/Fishwaldo/u-boot.git
synced 2025-06-25 08:03:18 +00:00
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
parent
02ff91e8c6
commit
b75d8dc564
489 changed files with 801 additions and 784 deletions
|
@ -76,7 +76,7 @@ int dram_init_banksize(void)
|
|||
/*
|
||||
* mmc_init - Initializes mmc
|
||||
*/
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
int ret = 0;
|
||||
|
||||
|
|
|
@ -83,7 +83,7 @@ int dram_init_banksize(void)
|
|||
/*
|
||||
* mmc_init - Initializes mmc
|
||||
*/
|
||||
int board_mmc_init(bd_t *bis)
|
||||
int board_mmc_init(struct bd_info *bis)
|
||||
{
|
||||
int ret = 0;
|
||||
|
||||
|
|
|
@ -75,7 +75,7 @@ void smp_waitloop(unsigned previous_address)
|
|||
#endif
|
||||
|
||||
#ifdef CONFIG_BCM_SF2_ETH
|
||||
int board_eth_init(bd_t *bis)
|
||||
int board_eth_init(struct bd_info *bis)
|
||||
{
|
||||
int rc = -1;
|
||||
printf("Registering BCM sf2 eth\n");
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue