GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-03-20 22:21:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

efi_loader: correct file creation

Browse source 
The EFI shell expects that after opening a file with EFI_FILE_MODE_CREATE
GetInfo() succeeds. Up to now we do not actually create the file when
method Open() of the EFI_FILE_PROTOCOL is called.

If method Open() of the EFI_FILE_PROTOCOL is called with
EFI_FILE_MODE_CREATE and the file does not yet exist, call fs_write() with
a buffer size of zero to actually create the file.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
This commit is contained in:
Heinrich Schuchardt 2019-04-06 16:27:34 +02:00
parent 19b2d895fb
commit cb0c2a7430
1 changed files with 27 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
lib/efi_loader/efi_file.c
View file

@ -134,6 +134,25 @@ static int sanitize_path(char *path)
return 0; return 0;
} }
/**
* efi_create_file() - create file or directory
*
* @fh: file handle
* @attributes: attributes for newly created file
* Returns: 0 for success
*/
static int efi_create_file(struct file_handle *fh, u64 attributes)
{
loff_t actwrite;
void *buffer = &actwrite;
if (attributes & EFI_FILE_DIRECTORY)
return fs_mkdir(fh->path);
else
return fs_write(fh->path, map_to_sysmem(buffer), 0, 0,
&actwrite);
}
/** /**
* file_open() - open a file handle * file_open() - open a file handle
* *
@ -176,6 +195,7 @@ static struct efi_file_handle *file_open(struct file_system *fs,
if (parent) { if (parent) {
char *p = fh->path; char *p = fh->path;
int exists;
if (plen > 0) { if (plen > 0) {
strcpy(p, parent->path); strcpy(p, parent->path);
@ -192,18 +212,17 @@ static struct efi_file_handle *file_open(struct file_system *fs,
if (set_blk_dev(fh)) if (set_blk_dev(fh))
goto error; goto error;
if ((mode & EFI_FILE_MODE_CREATE) && exists = fs_exists(fh->path);
(attributes & EFI_FILE_DIRECTORY)) {
if (fs_mkdir(fh->path))
goto error;
} else if (!((mode & EFI_FILE_MODE_CREATE) ||
fs_exists(fh->path)))
goto error;
/* fs_exists() calls fs_close(), so open file system again */ /* fs_exists() calls fs_close(), so open file system again */
if (set_blk_dev(fh)) if (set_blk_dev(fh))
goto error; goto error;
if (!exists) {
if (!(mode & EFI_FILE_MODE_CREATE) ||
efi_create_file(fh, attributes))
goto error;
}
/* figure out if file is a directory: */ /* figure out if file is a directory: */
fh->isdir = is_dir(fh); fh->isdir = is_dir(fh);
} else { } else {