GitHub-Mirror/u-boot
2
0
Fork 0
mirror of https://github.com/Fishwaldo/u-boot.git synced 2025-03-20 22:21:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

ot1200: Fix error handling in board_mmc_init()

Browse source 
When an invalid USDHC port is passed we should return -EINVAL instead of 0.

Also, return the error immediately on fsl_esdhc_initialize() failure.

Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
This commit is contained in:
Fabio Estevam 2014-11-21 16:42:56 -02:00 • committed by Stefano Babic
parent 44b9841d78
commit e37197acad
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
board/bachmann/ot1200/ot1200.c
View file

@ -173,7 +173,7 @@ struct fsl_esdhc_cfg usdhc_cfg[2] = {
int board_mmc_init(bd_t *bis) int board_mmc_init(bd_t *bis)
{ {
s32 status = 0; int ret;
u32 index = 0; u32 index = 0;
usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK); usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);
@ -196,13 +196,15 @@ int board_mmc_init(bd_t *bis)
printf("Warning: you configured more USDHC controllers" printf("Warning: you configured more USDHC controllers"
"(%d) then supported by the board (%d)\n", "(%d) then supported by the board (%d)\n",
index + 1, CONFIG_SYS_FSL_USDHC_NUM); index + 1, CONFIG_SYS_FSL_USDHC_NUM);
return status; return -EINVAL;
} }
status |= fsl_esdhc_initialize(bis, &usdhc_cfg[index]); ret = fsl_esdhc_initialize(bis, &usdhc_cfg[index]);
if (ret)
return ret;
} }
return status; return 0;
} }
#define PC MUX_PAD_CTRL(I2C_PAD_CTRL) #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)