mirror of
https://github.com/Fishwaldo/u-boot.git
synced 2025-03-17 12:41:32 +00:00
sysreset: Remove DM_FLAG_PRE_RELOC flag in various drivers
When a driver declares DM_FLAG_PRE_RELOC flag, it wishes to be bound before relocation. However due to a bug in the DM core, the flag only takes effect when devices are statically declared via U_BOOT_DEVICE(). This bug has been fixed recently by commit "dm: core: Respect drivers with the DM_FLAG_PRE_RELOC flag in lists_bind_fdt()", but with the fix, it has a side effect that all existing drivers that declared DM_FLAG_PRE_RELOC flag will be bound before relocation now. This may expose potential boot failure on some boards due to insufficient memory during the pre-relocation stage. To mitigate this potential impact, the following changes are implemented: - Remove DM_FLAG_PRE_RELOC flag in the driver, if the driver only supports configuration from device tree (OF_CONTROL) - Keep DM_FLAG_PRE_RELOC flag in the driver only if the device is statically declared via U_BOOT_DEVICE() - Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for drivers that support both statically declared devices and configuration from device tree Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
parent
4687919684
commit
ef329a6a73
3 changed files with 0 additions and 3 deletions
|
@ -44,5 +44,4 @@ U_BOOT_DRIVER(tangier_sysreset) = {
|
|||
.id = UCLASS_SYSRESET,
|
||||
.of_match = tangier_sysreset_ids,
|
||||
.ops = &tangier_sysreset_ops,
|
||||
.flags = DM_FLAG_PRE_RELOC,
|
||||
};
|
||||
|
|
|
@ -45,5 +45,4 @@ U_BOOT_DRIVER(x86_sysreset) = {
|
|||
.id = UCLASS_SYSRESET,
|
||||
.of_match = x86_sysreset_ids,
|
||||
.ops = &x86_sysreset_ops,
|
||||
.flags = DM_FLAG_PRE_RELOC,
|
||||
};
|
||||
|
|
|
@ -161,5 +161,4 @@ U_BOOT_DRIVER(efi_sysreset) = {
|
|||
.id = UCLASS_SYSRESET,
|
||||
.of_match = efi_sysreset_ids,
|
||||
.ops = &efi_sysreset_ops,
|
||||
.flags = DM_FLAG_PRE_RELOC,
|
||||
};
|
||||
|
|
Loading…
Add table
Reference in a new issue