Giacomo Guiduzzi 753f4fd89d ALSA: pci: fix reading of swapped values from pcmreg in AC97 codec ... commit 17aaf01933 upstream. Tests 72 and 78 for ALSA in kselftest fail due to reading inconsistent values from some devices on a VirtualBox Virtual Machine using the snd_intel8x0 driver for the AC'97 Audio Controller device. Taking for example test number 72, this is what the test reports: "Surround Playback Volume.0 expected 1 but read 0, is_volatile 0" "Surround Playback Volume.1 expected 0 but read 1, is_volatile 0" These errors repeat for each value from 0 to 31. Taking a look at these error messages it is possible to notice that the written values are read back swapped. When the write is performed, these values are initially stored in an array used to sanity-check them and write them in the pcmreg array. To write them, the two one-byte values are packed together in a two-byte variable through bitwise operations: the first value is shifted left by one byte and the second value is stored in the right byte through a bitwise OR. When reading the values back, right shifts are performed to retrieve the previously stored bytes. These shifts are executed in the wrong order, thus reporting the values swapped as shown above. This patch fixes this mistake by reversing the read operations' order. Signed-off-by: Giacomo Guiduzzi <guiduzzi.giacomo@gmail.com> Signed-off-by: Paolo Valente <paolo.valente@linaro.org> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/20220322200653.15862-1-guiduzzi.giacomo@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-04-19 17:46:24 +08:00
..
ac97	bus: Make remove callback return void	2021-07-21 11:53:42 +02:00
aoa	Kbuild updates for v5.15	2021-09-03 15:33:47 -07:00
arm	ALSA: pxa2xx: Use managed PCM buffer allocation	2021-08-04 08:08:21 +02:00
atmel
core	ALSA: pcm: Add stream lock during PCM reset ioctl operations	2023-04-19 17:46:24 +08:00
drivers	ALSA: drivers: opl3: Fix incorrect use of vp->state	2023-04-19 17:43:24 +08:00
firewire	ALSA: oxfw: fix functional regression for Mackie Onyx 1640i in v5.14 or later	2023-04-19 16:57:40 +08:00
hda	ALSA: hda: Make proper use of timecounter	2023-04-19 17:44:12 +08:00
i2c
isa	ALSA: gus: fix null pointer dereference on pointer block	2023-04-19 17:42:08 +08:00
mips
oss
parisc	parisc architecture updates for kernel 5.15:	2021-09-02 13:16:00 -07:00
pci	ALSA: pci: fix reading of swapped values from pcmreg in AC97 codec	2023-04-19 17:46:24 +08:00
pcmcia	ALSA: vx: Manage vx_core object with devres	2021-07-19 16:17:09 +02:00
ppc	ALSA: ppc: fix error return code in snd_pmac_probe()	2021-06-16 08:52:29 +02:00
sh
soc	ASoC: sti: Fix deadlock via snd_pcm_stop_xrun() call	2023-04-19 17:46:23 +08:00
sparc
spi
synth	ALSA: synth: missing check for possible NULL after the call to kstrdup	2023-04-19 16:56:56 +08:00
usb	ALSA: usb-audio: Add mute TLV for playback volumes on RODE NT-USB	2023-04-19 17:46:24 +08:00
virtio
x86	ALSA: intel_hdmi: Fix reference to PCM buffer address	2023-04-19 17:45:56 +08:00
xen
ac97_bus.c
Kconfig
last.c	[Audio: I2S & WM8960] Porting i2s to match wm8960 driver	2022-06-20 18:55:45 -07:00
Makefile
sound_core.c