mirror of
https://github.com/Fishwaldo/opensbi.git
synced 2025-03-15 19:31:32 +00:00
lib: utils: Simplify SET_ISA_EXT_MAP()
The define is hard to read. The continue statement does not do what was
intended.
* Remove do {} while (false);
* Change the name to set_multi_letter_ext
- Other local macros are lower case too.
- Refer to the fact that this is only used for multi-letter extensions.
Addresses-Coverity-ID: 1568359 Unexpected control flow
Fixes: d72f5f1747
("lib: utils: Add detection of Smepmp from ISA string in FDT")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
parent
9da30f6105
commit
942aca232e
1 changed files with 4 additions and 6 deletions
|
@ -369,16 +369,14 @@ static int fdt_parse_isa_one_hart(const char *isa, unsigned long *extensions)
|
|||
if (!j)
|
||||
continue;
|
||||
|
||||
#define SET_ISA_EXT_MAP(name, bit) \
|
||||
do { \
|
||||
#define set_multi_letter_ext(name, bit) \
|
||||
if (!strcmp(mstr, name)) { \
|
||||
__set_bit(bit, extensions); \
|
||||
continue; \
|
||||
} \
|
||||
} while (false) \
|
||||
}
|
||||
|
||||
SET_ISA_EXT_MAP("smepmp", SBI_HART_EXT_SMEPMP);
|
||||
#undef SET_ISA_EXT_MAP
|
||||
set_multi_letter_ext("smepmp", SBI_HART_EXT_SMEPMP);
|
||||
#undef set_multi_letter_ext
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Add table
Reference in a new issue